Skip to content

fix: prevent retry delay overflow#679

Open
redactdeveloper wants to merge 1 commit into
openai:mainfrom
redactdeveloper:fix/retry-delay-overflow
Open

fix: prevent retry delay overflow#679
redactdeveloper wants to merge 1 commit into
openai:mainfrom
redactdeveloper:fix/retry-delay-overflow

Conversation

@redactdeveloper

Copy link
Copy Markdown

Summary

  • Prevent retry backoff from overflowing time.Duration for large retry counts.
  • Replace the floating-point exponential calculation with bounded duration doubling.
  • Add a regression test covering large retry counts so jitter never receives an invalid bound.

Fixes #489

Test plan

  • go test ./internal/requestconfig -run 'TestRetryDelay' -count=1
  • go test ./internal/requestconfig -count=1

@redactdeveloper
redactdeveloper requested a review from a team as a code owner June 3, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in retryDelay due to integer overflow on x86 architecture

1 participant