test(ui): stabilize Control UI suite routing - #100108

Best possible solution:

Land the narrow routing and test-isolation fix once current CI completes, keeping both UI Vitest configs aligned with the route-owned pages layout.

Do we have a high-confidence way to reproduce the issue?

Yes from source inspection: current main points both UI Vitest routing configs at old src/ui browser-test paths while the files now exist under ui/src/pages. I did not run tests locally because this review is read-only.

Is this the best way to solve the issue?

Yes. Updating both routing configs and isolating the leaking display mock is the narrow maintainable fix for a test-only stabilization, with no new product or config surface.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 4682364fa6f4.

Label changes:

• add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external contributor proof gate does not apply because this is a maintainer-authored test-only PR; validation remains normal CI/Testbox evidence.

Label justifications:

• P3: This is a low-risk maintainer test-stabilization PR for Control UI routing, not a user-facing regression or release blocker.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external contributor proof gate does not apply because this is a maintainer-authored test-only PR; validation remains normal CI/Testbox evidence.

PR surface:

Source 0, Tests +3. Total +3 across 4 files.

What I checked:

• PR diff reviewed: The patch changes only UI tests and Vitest routing: it updates moved browser-layout test paths in both UI Vitest configs, adds a chat-avatar unmock, and relaxes one side-result text assertion around markdown formatting. (f3bc230d7f3f)
• Current main has stale UI routing paths: Current main still routes node-driven browser layout tests through old src/ui paths for chat-responsive and sessions, while the actual files now live under src/pages. (ui/vitest.config.ts:62, 4682364fa6f4)
• Node-only config prior finding is addressed: The previous ClawSweeper finding asked to sync the node-only UI Vitest config; the current PR head updates those same two moved browser-layout paths in ui/vitest.node.config.ts. (ui/vitest.node.config.ts:11, f3bc230d7f3f)
• Shared routing invariant checked: The main UI Vitest config uses nodeDrivenBrowserLayoutTests both to include tests in the unit-node project and exclude them from the browser project, so the path list must match the moved files exactly. (ui/vitest.config.ts:130, 4682364fa6f4)
• Mock leak context checked: Neighbor chat tests mock lib/agents/display.ts with isolate disabled; the chat-avatar test imports the real display helpers, so the PR's explicit unmock is a focused suite-order guard. (ui/src/pages/chat/components/chat-message.test.ts:63, 4682364fa6f4)
• Control UI refactor provenance: The moved page test files and most Control UI route restructuring came from merged PR feat: refactor the Control UI architecture #100024, whose merge commit added the new pages test paths while leaving some old routing entries behind. (ui/vitest.config.ts:62, 65e12328aa20)

Likely related people:

• shakkernerd: Authored and merged the Control UI architecture refactor that moved the relevant tests under ui/src/pages and changed the nearby Vitest routing surface. (role: recent area contributor; confidence: high; commits: 65e12328aa20; files: ui/vitest.config.ts, ui/src/pages/chat/chat-responsive.browser.test.ts, ui/src/pages/sessions/view.browser.test.ts)
• sunlit-deng: Blame on the old node-driven browser layout entries points to the pre-refactor config baseline carried forward into current main, though the commit itself was not a UI-routing change. (role: historical config contributor; confidence: low; commits: 364494623051; files: ui/vitest.config.ts, ui/vitest.node.config.ts)

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

• reviewed 2026-07-04T23:10:29.074Z sha 3c8f1c3ef95b9ae3443f8bc0c837f87b4801ae2e :: needs changes before merge. :: [P2] Sync the node-only UI Vitest config
• reviewed 2026-07-04T23:16:04.650Z sha 3c8f1c3ef95b9ae3443f8bc0c837f87b4801ae2e :: needs changes before merge. :: [P2] Sync the node-only UI Vitest config