Skip to content

refactor(qa-lab): localize orchestration declarations - #102005

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v79
Jul 8, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v79

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Seven QA Lab orchestration declarations were exported even though they have no repository consumers and are not part of the package's explicit public API.

Why This Change Was Made

Keep these declarations local to their owning modules while preserving the exported functions and result types that form the actual QA Lab surface. QaModelSelection was deliberately left exported because model-selection.ts is re-exported through a wildcard barrel.

User Impact

None. This is export-surface cleanup only; runtime behavior and supported QA Lab APIs are unchanged.

Evidence

  • Fresh codebase-memory graph: 281,363 nodes / 1,134,383 edges.
  • MCP graph search and repository-wide exact search found no external consumers or explicit barrel exports for the seven localized declarations.
  • Testbox tbx_01kwzvzf75590qyxg6nkfwcdm2: post-rebase pnpm check:changed passed, including core and extension type/lint lanes.
  • Seven focused patched suites passed: 70/70 tests.
  • Full build passed after rebasing onto current origin/main.
  • A wider eight-suite run was 70/71 because ci-smoke-plan.test.ts expects 89 scenarios while current main produces 98; the identical failure was reproduced on pristine current main.
  • Fresh autoreview: local 0.89, pre-rebase branch 0.87, post-rebase branch 0.91; no accepted/actionable findings.

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for 98b5809af06a334578ae9d143b2ca242c79431ad:

  • Fresh codebase-memory index: 281,363 nodes / 1,134,383 edges.
  • Graph and repository-wide searches found no consumers or explicit barrel exports for the seven localized declarations. QaModelSelection remains exported because its module is exposed through a wildcard barrel.
  • Testbox tbx_01kwzvzf75590qyxg6nkfwcdm2: post-rebase pnpm check:changed passed, including core and extension type/lint lanes.
  • Seven focused QA Lab suites passed: 70/70.
  • Full build passed after rebasing onto current origin/main.
  • Wider eight-suite run: 70/71. The remaining ci-smoke-plan.test.ts scenario-count assertion (expected 89, current catalog 98) reproduces unchanged on pristine current main.
  • Fresh autoreview is clean: local 0.89, pre-rebase branch 0.87, post-rebase branch 0.91.
  • scripts/pr review-validate-artifacts 102005 and OPENCLAW_TESTBOX=1 scripts/pr prepare-run 102005 passed with zero findings.

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 03:49
@vincentkoc
vincentkoc merged commit 757d7a0 into main Jul 8, 2026
116 of 118 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v79 branch July 8, 2026 03:50
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant