Repository navigation
test(ui): wait for the selected catalog pane before checking authors - #139286
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Contributor
|
Codex review: needs maintainer review before merge. Reviewed September 5, 2026, 2:38 PM ET / 18:38 UTC. ClawSweeper reviewWhat this changesThe browser test waits for the selected external transcript pane before checking author names, avatars, and profile links. Merge readiness✅ Ready for maintainer review No blocking findings. This remains a useful test-readiness improvement absent from inspected main; the protected maintainer PR should proceed through ordinary validation. Priority: P3 Review scores
Verification
How this fits togetherThe Control UI retains transcript panes while users switch sessions. This browser test supplies catalog fixtures and checks author presentation in the selected pane. flowchart LR
A[Catalog fixtures] --> B[Sidebar selection]
B --> C[Retained transcript panes]
C --> D{Selected pane visible?}
D -->|Yes| E[Check authors and avatars]
D -->|No| F[Wait within existing deadline]
Before mergeNone. Agent review detailsSecurityNone. PR surfaceTests +11. Total +11 across 1 file. View PR surface stats
Review metrics
Technical reviewBest possible solution: Keep sidebar-driven selection and wait for its pane identity before applying the existing presentation assertions. Do we have a high-confidence way to reproduce the issue? No high-confidence reproduction of the original CI failure is established; the author explicitly reports unsuccessful reproduction, although source confirms shared content cannot identify the selected catalog. Is this the best way to solve the issue? Yes, for the stated readiness cleanup: the predicate follows the existing navigation contract while preserving the sidebar click and all behavioral assertions. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against be344135ef47. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The external-catalog author E2E selects three retained panes that contain identical transcript text and avatar bytes. Waiting for that shared content alone does not establish that navigation reached the selected catalog.
Why This Change Was Made
Wait for the intended visible pane's session key before reading its transcript, following the existing
navigateToControlUiSessionreadiness contract. All author, avatar, unknown-author, and Activity-link assertions remain intact. No timeout, retry, or production behavior changes.User Impact
Test-only readiness cleanup: the checks explicitly inspect the requested external transcript.
Evidence
Related: #138900. Its original UI shard failure observed zero uploader-profile links during a Beam-to-Claude switch. The exact CI interleaving was not reproduced locally; this PR does not claim a product defect or conclusively explain that failure.
The unchanged local Riley/Morgan cases reported passes, but their runner later exited through its existing no-output watchdog. A separate browser replay against the unchanged production UI passed 30 original and 30 synchronized navigation/assertion sets under CPU throttling. Formatting and independent Codex review passed. Current-head CI remains the clean full-run gate.
Production delta: 0. Test delta: +11 lines.