Repository navigation
test(plugins): share account policy inheritance fixtures - #139696
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
steipete
marked this pull request as ready for review
September 6, 2026 03:48
Contributor
|
Codex review: needs maintainer review before merge. Reviewed September 5, 2026, 11:54 PM ET / September 6, 2026, 03:54 UTC. ClawSweeper reviewWhat this changesShares account-policy test fixtures across seven channel plugins while preserving their independent validation and assertions, and documents the helper. Merge readiness✅ Ready for maintainer review Keep open: this is a useful, maintainer-sponsored cleanup that current main has not incorporated. The fixture extraction preserves all seven suites’ inputs, callbacks, assertions, and additional cases; no actionable defect was found. Priority: P3 Review scores
Verification
How this fits togetherChannel account-policy tests check how account settings inherit or override channel settings. Shared fixtures feed each plugin’s schema parser, host validation, and account resolver before plugin-specific assertions check the result. flowchart LR
A[Shared policy fixtures] --> B[Plugin schema parsing]
B --> C[Host config validation]
C --> D[Plugin account resolver]
D --> E[Inheritance assertions]
B --> F[Omitted-field assertions]
Before mergeNone. Agent review detailsSecurityNone. PR surfaceTests -122, Docs +8. Total -114 across 10 files. View PR surface stats
Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Keep one fresh fixture factory while retaining each plugin’s independent schema, resolver, and policy assertions. Do we have a high-confidence way to reproduce the issue? Not applicable: this is fixture deduplication, not a reported runtime defect; the repeated inputs and their preservation are directly verifiable from source. Is this the best way to solve the issue? Yes: a fresh literal factory removes duplication without centralizing plugin-specific assertions or adding a shipped API. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 4e330557ae33. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #139428
What Problem This Solves
Seven channel plugin suites repeat the same account-policy inheritance fixture rows, making the shared regression inputs harder to maintain consistently.
Why This Change Was Made
Provide four fresh literal rows through the existing channel test-helper surface. Each plugin keeps its own schema parsing, host validation, account resolver and assertions. Omitted properties stay omitted; Telegram and Slack's additional cases remain intact. Document the helper's scope.
User Impact
No plugin runtime or policy behavior changes. Net 122 test/support lines removed, with eight documentation lines added. All 41 existing tests remain selected.
Evidence
All seven suites pass 41/41 before and after with identical full test identities. Runtime fixture comparisons preserve values, property absence and fresh nested allocations; expanded-source comparison confirms unchanged callbacks, assertions and extra cases.
The full changed gate passes, including SDK exports/surface, plugin boundaries, core and extension typechecks, dead exports and lint. Docs formatting/MDX checks, diff checks, deslop and final independent P2 review pass. Cache warmth differs between timing samples; no performance improvement is claimed.