Skip to content

refactor(tests): reuse setup runtime fixtures #139920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steipete merged 1 commit into from
Sep 6, 2026
+18 −53
Merged

refactor(tests): reuse setup runtime fixtures #139920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 18 additions & 53 deletions src/commands/setup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { createConfigIO } from "../config/io.js";
import { replaceConfigFile } from "../config/mutate.js";
import type { OpenClawConfig } from "../config/types.js";
import { setupCommand } from "./setup.js";
import { createTestRuntime } from "./test-runtime-config-helpers.js";

function createSetupDeps(home: string) {
const configPath = path.join(home, ".openclaw", "openclaw.json");
Expand Down Expand Up @@ -59,11 +60,7 @@ function requireFirstWorkspaceParams(
describe("setupCommand", () => {
it("writes gateway.mode=local on first run", async () => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const deps = createSetupDeps(home);
const workspace = path.join(home, ".openclaw", "workspace");

Expand Down Expand Up @@ -98,11 +95,7 @@ describe("setupCommand", () => {

it("explains that plain setup only initializes local files", async () => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const deps = createSetupDeps(home);

await setupCommand(undefined, runtime, deps);
Expand All @@ -119,11 +112,7 @@ describe("setupCommand", () => {

it("emits one structured result for baseline JSON output", async () => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const deps = createSetupDeps(home);
const workspace = path.join(home, ".openclaw", "workspace");

Expand All @@ -142,7 +131,7 @@ describe("setupCommand", () => {

it("updates the default entry workspace created by fresh setup", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const deps = createSetupDeps(home);
const initialWorkspace = path.join(home, "initial-workspace");
const nextWorkspace = path.join(home, "next-workspace");
Expand All @@ -161,7 +150,7 @@ describe("setupCommand", () => {

it("keeps the default entry workspace on bare setup", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const workspace = "/srv/ops";
Expand Down Expand Up @@ -189,7 +178,7 @@ describe("setupCommand", () => {

it("does not copy an entry workspace into defaults during a gateway-only write", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const workspace = "/srv/ops";
Expand Down Expand Up @@ -218,11 +207,7 @@ describe("setupCommand", () => {

it("adds gateway.mode=local to an existing config without overwriting workspace", async () => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const workspace = path.join(home, "custom-workspace");
Expand Down Expand Up @@ -254,7 +239,7 @@ describe("setupCommand", () => {

it("leaves an include-owned roster in its authored file", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const includePath = path.join(configDir, "agents.json");
Expand Down Expand Up @@ -290,7 +275,7 @@ describe("setupCommand", () => {

it("updates only inherited workspace defaults beside an include-owned roster", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const includePath = path.join(configDir, "agents.json");
Expand Down Expand Up @@ -327,7 +312,7 @@ describe("setupCommand", () => {

it("updates inherited workspace defaults below a nested roster include", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const includePath = path.join(configDir, "agents.json");
Expand Down Expand Up @@ -369,7 +354,7 @@ describe("setupCommand", () => {

it("persists a roster when existing setup settings already match", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const workspace = path.join(home, "workspace");
Expand Down Expand Up @@ -397,11 +382,7 @@ describe("setupCommand", () => {

it("threads skipOptionalBootstrapFiles into workspace creation", async () => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const deps = createSetupDeps(home);
Expand Down Expand Up @@ -433,11 +414,7 @@ describe("setupCommand", () => {
"rejects a foreign write before the final config commit (fresh: %s)",
async (fresh) => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const workspace = path.join(home, "custom-workspace");
Expand Down Expand Up @@ -473,11 +450,7 @@ describe("setupCommand", () => {
"preserves malformed config and reports failure (json: %s)",
async (json) => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const deps = createSetupDeps(home);
Expand Down Expand Up @@ -522,11 +495,7 @@ describe("setupCommand", () => {
"preserves an existing %s config root and stops before setup mutations",
async (_label, raw) => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const deps = createSetupDeps(home);
Expand All @@ -549,11 +518,7 @@ describe("setupCommand", () => {

it("uses systemAgent.agentId in multi-agent explicit mode", async () => {
await withTempHome(async (home) => {
const runtime = {
log: vi.fn(),
error: vi.fn(),
exit: vi.fn(),
};
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const deps = createSetupDeps(home);
Expand Down Expand Up @@ -584,7 +549,7 @@ describe("setupCommand", () => {

it("gives an actionable error when baseline setup has no ambient owner", async () => {
await withTempHome(async (home) => {
const runtime = { log: vi.fn(), error: vi.fn(), exit: vi.fn() };
const runtime = createTestRuntime();
const configDir = path.join(home, ".openclaw");
const configPath = path.join(configDir, "openclaw.json");
const deps = createSetupDeps(home);
Expand Down
Loading