Skip to content

chore(i18n): refresh native locales - #139921

Merged
openclaw-mantis[bot] merged 1 commit into
mainfrom
automation/native-app-locale-refresh
Sep 6, 2026
Merged

openclaw-mantis[bot] merged 1 commit into
mainfrom
automation/native-app-locale-refresh

Conversation

@openclaw-mantis

@openclaw-mantis openclaw-mantis Bot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Keeps generated native app locales synchronized without bypassing protected-branch checks.

Why This Change Was Made

The Native App Locale Refresh workflow generated this update from 5e0fc11f08dd4f01a0335a045907417902d8311f and published it through a reviewable automation branch.

User Impact

No direct user-facing change beyond refreshed translations.

Evidence

@clawsweeper

clawsweeper Bot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@openclaw-mantis
openclaw-mantis Bot enabled auto-merge (squash) September 6, 2026 08:04
@clawsweeper clawsweeper Bot added P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Sep 6, 2026
@clawsweeper

clawsweeper Bot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed September 6, 2026, 6:58 AM ET / 10:58 UTC.

ClawSweeper review

What this changes

Refreshes native translations and the Apple string catalog to match the existing Apple Watch connection and voice-setup instructions.

Merge readiness

✅ Ready for maintainer review

Keep this repository-managed locale refresh open for its publisher. The translations remain needed on the inspected main revision, and no actionable correctness or security defect was found.

Priority: P3
Reviewed head: 1a3e133edcfda2fbe37307d4e948baa10e6ac543

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, consistent generated refresh with no actionable findings and appropriate supplied locale validation.
Proof confidence 🌊 off-meta tidepool Not applicable: This canonical bot-generated resource refresh is exempt from contributor runtime proof; source/catalog consistency and supplied native-i18n success support the review, without claiming an observed native UI run.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: This canonical bot-generated resource refresh is exempt from contributor runtime proof; source/catalog consistency and supplied native-i18n success support the review, without claiming an observed native UI run.
Evidence reviewed 7 items Publisher-owned generated PR: The supplied GitHub snapshot identifies the canonical automation/native-app-locale-refresh branch and openclaw-mantis bot author. The workflow publishes that exact branch and owns automatic merging after checks.
Translations match existing source: The source inventory contains all five replacement strings and identifies their iPhone settings and Watch consumers. The settings button already says Connect Apple Watch, and its footer already describes included voice access and explicit microphone activation.
Complete resource consistency inspection: Read-only JSON comparison of the pinned base and head parsed all 21 changed locale artifacts and the Apple catalog. Each locale adds the same five current strings and removes six obsolete IDs; retained values and metadata are unchanged. Every added catalog translation matches its locale artifact, and no removed catalog key remains in the source inventory. No consistency errors were found; git diff --check also passed.
Findings None None.
Security None None.

How this fits together

Native localization maps English source strings to translated app resources. These resources supply the connection controls, status messages, and setup guidance displayed on iPhone and Apple Watch.

flowchart LR
  A[Native app source text] --> B[Source string inventory]
  B --> C[Locale translations]
  C --> D[Apple string catalog]
  D --> E[iPhone setup guidance]
  D --> F[Apple Watch status and guidance]
Loading

Before merge

None.

Agent review details

Security

None.

PR surface

Other -22. Total -22 across 22 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 0 0 0 0
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 22 110 132 -22
Total 22 110 132 -22

Review metrics

None.

Technical review

Best possible solution:

Keep translated resources synchronized with the canonical source inventory through the existing locale publisher and its required checks.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this generated-resource refresh reports no runtime defect; source inspection establishes the translation drift it addresses.

Is this the best way to solve the issue?

Yes. Updating the existing locale artifacts and derived Apple catalog follows the documented ownership boundary without introducing a competing localization path.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 305147ec9638.

Labels

Label justifications:

  • P3: This is a bounded translation refresh for existing native setup guidance, with no runtime or configuration change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This canonical bot-generated resource refresh is exempt from contributor runtime proof; source/catalog consistency and supplied native-i18n success support the review, without claiming an observed native UI run.

Evidence

What I checked:

  • Publisher-owned generated PR: The supplied GitHub snapshot identifies the canonical automation/native-app-locale-refresh branch and openclaw-mantis bot author. The workflow publishes that exact branch and owns automatic merging after checks. (.github/workflows/native-app-locale-refresh.yml:249, 1a3e133edcfd)
  • Translations match existing source: The source inventory contains all five replacement strings and identifies their iPhone settings and Watch consumers. The settings button already says Connect Apple Watch, and its footer already describes included voice access and explicit microphone activation. (apps/ios/Sources/Design/SettingsProTabSections.swift:498, 1a3e133edcfd)
  • Complete resource consistency inspection: Read-only JSON comparison of the pinned base and head parsed all 21 changed locale artifacts and the Apple catalog. Each locale adds the same five current strings and removes six obsolete IDs; retained values and metadata are unchanged. Every added catalog translation matches its locale artifact, and no removed catalog key remains in the source inventory. No consistency errors were found; git diff --check also passed. (apps/ios/Resources/Localizable.xcstrings:313, 1a3e133edcfd)
  • Refresh remains necessary on inspected main: The fetched main revision still contains the old device-token explanation in the German artifact and lacks the replacement IDs queried here. This supports retaining the refresh rather than treating it as already implemented. The latest-release blob could not be inspected because fetching its missing object failed; no shipped-version claim is made. (apps/.i18n/native/de.json, 305147ec9638)
  • Established generated-resource workflow: Current CI documentation explicitly separates source changes from serialized locale refresh PRs and requires translated/platform-generated parity for generated PRs. The supplied head-check snapshot records native-i18n success; this review did not execute repository scripts or tests. Public docs: docs/ci.md. (docs/ci.md:96, 1a3e133edcfd)
  • Area-history routing: Available main history records Peter Steinberger's native localization maintenance and Vincent Koc's placeholder-validation work. Exact-line blame and deeper patch inspection encountered unavailable objects, so these are routing candidates without introduction attribution. (scripts/native-app-i18n.ts, 305147ec9638)

Likely related people:

  • Peter Steinberger: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
  • Vincent Koc: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (2 earlier review cycles)
  • reviewed 2026-09-06T08:10:39.641Z sha 20fa954 :: needs maintainer review before merge. :: none
  • reviewed 2026-09-06T10:04:02.175Z sha 079879c :: needs maintainer review before merge. :: none

@openclaw-mantis
openclaw-mantis Bot disabled auto-merge September 6, 2026 08:51
@clawsweeper
clawsweeper Bot force-pushed the automation/native-app-locale-refresh branch from 20fa954 to d6b39b4 Compare September 6, 2026 09:29
@openclaw-mantis
openclaw-mantis Bot enabled auto-merge (squash) September 6, 2026 09:29
@clawsweeper
clawsweeper Bot force-pushed the automation/native-app-locale-refresh branch from d6b39b4 to 079879c Compare September 6, 2026 09:58
@openclaw-mantis
openclaw-mantis Bot disabled auto-merge September 6, 2026 10:18
@clawsweeper
clawsweeper Bot force-pushed the automation/native-app-locale-refresh branch from 079879c to 1a3e133 Compare September 6, 2026 10:53
@openclaw-mantis
openclaw-mantis Bot enabled auto-merge (squash) September 6, 2026 10:53
@openclaw-mantis
openclaw-mantis Bot merged commit 2b28525 into main Sep 6, 2026
120 checks passed
@openclaw-mantis
openclaw-mantis Bot deleted the automation/native-app-locale-refresh branch September 6, 2026 11:31
github-actions Bot added a commit to Desicool/openclaw that referenced this pull request Sep 7, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: ios App: ios P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: M status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants