Repository navigation
fix: show complete skill instructions in Workshop comparisons - #140300
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Dependency GuardThis PR changes dependency-related files. Maintainers should confirm these changes are intentional. Changed files:
Maintainer follow-up:
|
Dependency graph changes are blockedOpenClaw does not accept dependency graph changes through PRs unless a repository admin or security explicitly authorizes the current head SHA. Dependency updates are generated internally by maintainers so external PRs cannot change the resolved graph. Detected dependency graph changes:
Auto-scrub was not attempted because this PR changes package manifest dependency graph fields:
Dependency graph changes must be reviewed by security or handled by maintainers internally. Please remove lockfile changes manually if they are not needed. To remove lockfile changes, restore them from the target branch: git fetch origin
git checkout 'origin/main' -- 'pnpm-lock.yaml'
git commit -m 'chore: remove dependency lockfile change'
git pushIf this PR intentionally needs a dependency graph change, ask a repository admin or member of The action will approve the current head SHA ( |
|
Codex review: blocked before merge. Reviewed September 6, 2026, 10:01 PM ET / September 7, 2026, 02:01 UTC. ClawSweeper reviewWhat this changesWorkshop compares complete saved and current skill instructions in a browser worker, preserves blank lines, and keeps current instructions readable while comparisons load. Merge readiness⛔ Blocked before merge - 4 items remain The fix remains useful: current main still produces shortened Workshop comparisons. No actionable code defect was found, and the retained packaged-Gateway proof is sufficient; the remaining hold is verification of the dependency and restricted-path authorization. Priority: P2 Review scores
Verification
How this fits togetherThe Workshop page reads installed skills and retained applied proposals from the Gateway. It compares their instruction bodies and displays changes for operators reviewing their skills. flowchart LR
A[Installed skill] --> C[Workshop reader]
B[Saved applied proposals] --> C
C --> D[Validate matching skill]
D --> E[Browser comparison worker]
C --> F[Readable current instructions]
E --> G[Complete inline comparison]
Decision needed
Why: The newer approval addresses the prior hold, but its qualifying authority could not be verified and the captured dependency guard remains blocked. Before merge
Agent review detailsSecurityNone. PR surfaceSource +99, Tests +139, Docs +2, Config +1, Other +3. Total +244 across 19 files. View PR surface stats
Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the complete-document worker implementation and shared safe renderer, with the intentional UI dependency importer covered by verified repository authorization. Do we have a high-confidence way to reproduce the issue? Yes: current main's compacted, capped comparison path explains omitted instructions and late edits; the retained packaged baseline observations corroborate it. No runtime reproduction was executed in this review. Is this the best way to solve the issue? Yes: a Workshop-specific complete comparison using the existing pinned library preserves bounded chat previews and reuses the safe renderer without adding settings or storage changes. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 77f62904ae7c. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (4 earlier review cycles)
|
|
Recording Ayaan's explicit approval to land this PR's intentional dependency change at head The change adds the UI importer for the already-pinned This approval does not waive required CI, the local review gate, or the remaining packaged-Gateway browser proof. It is not a claim of secops membership or a |
|
landpr-approve-admin-merge |
|
Landed as 52dd6629 with green required CI and a clean exact-head ClawSweeper review. Proof: The packaged Workshop reader shows complete skill instructions with inline changes, including blank lines and late edits. The fresh independent review found no code or security issues and accepted the retained packaged proof for the type-only refresh.
|
…aw#140300) Show complete skill instructions with inline changes in one scrollable Workshop reader. Reuse the pinned diff library and shared escaped renderer, with off-thread comparisons and readable current content while saved versions load. Remove clipped-preview state and the duplicate-document fallback. Preserve blank lines, saved-version ownership checks, and stale-read fencing. Verified baseline/candidate browser behavior, large rewrites, worker failure recovery, independent acceptance, focused tests, and exact-head review. Co-authored-by: Ayaan Zaidi <hi@obviy.us>
What Problem This Solves
Workshop skill comparisons showed short edit snippets instead of complete instructions, and late changes in long skills could disappear.
Why This Change Was Made
Use the existing diff library for full-document comparison with the shared escaped renderer. Run comparison off the main browser thread and keep current instructions readable while it loads; remove shortened-result and duplicate-document fallbacks.
User Impact
Users can read all instructions, blank lines, additions, and removals in one scrollable view. Frontmatter and supporting files remain outside comparisons; no storage or settings change.
Evidence
Packaged Gateway/browser checks reproduced shortened baseline views and verified complete 41-, 700-, and 3,800-line documents after repair. All four complete-document browser cases and 78 focused UI checks passed. A synthetic large rewrite reduced maximum frame gaps from 1.30–1.43 seconds to 0.167–0.183 seconds; it exceeds normal proposal-creation limits. Failure/retry checks kept current content readable.