Repository navigation
chore(ui): refresh 2026.9.8 control ui locales - #163409
Conversation
Import the reviewed silent-reply help translations from #162942 and regenerate metadata against the release candidate catalog. Co-authored-by: RomneyDa <6581799+RomneyDa@users.noreply.github.com> Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed October 2, 2026, 5:06 AM ET / 09:06 UTC. ClawSweeper reviewWhat this changesRefreshes translations for one silent-reply help string across 20 Control UI locales and regenerates metadata for the 2026.9.8 release catalog. Merge readiness⛔ Blocked before merge - 1 item remains Keep open: this is a focused release-branch repair, and the merged main-branch locale refresh does not replace its release-specific catalog metadata. No actionable introduced defect was found. Priority: P2 Review scores
Verification
How this fits togetherControl UI localization combines English UI copy and configuration help with generated translation memory. The build materializes localized catalogs, while release verification checks their completeness and source hashes. flowchart LR
A[English UI copy] --> C[Release source catalog]
B[Configuration help] --> C
C --> E[Locale materialization]
D[Translation memory] --> E
E --> F[Localized Control UI]
C --> G[Release locale verification]
D --> G
Before merge
Agent review detailsSecurityNone. PR surfaceSource 0. Total 0 across 41 files. View PR surface stats
Review metricsNone. Stored data modelPersistent data-model change detected: Technical reviewBest possible solution: Keep release-specific locale artifacts synchronized through the existing generator and strict locale verification. Do we have a high-confidence way to reproduce the issue? Not applicable to a current-main runtime bug: the reported failure is release-catalog drift, and the differing source hashes are visible in the inspected artifacts. Is this the best way to solve the issue? Yes. Reusing reviewed translations and regenerating release-specific metadata preserves the existing localization owner without duplicating implementation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 6000ebd389bf. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
What Problem This Solves
The 2026.9.8 release branch changed one Control UI silent-reply help string after its last locale refresh. Release preflight therefore rejected the candidate's generated locale metadata.
Solution
Import the reviewed per-locale translation-memory replacement from #162942 and regenerate metadata against the release branch's own 10,083-key catalog. This PR intentionally contains only owner-generated locale artifacts; source repairs remain in #163392.
Evidence
pnpm ui:i18n:check— all 20 locales clean, zero fallback keys.git diff --check 6bebbac77c70bb6a481a02d8da1739beef467c64...HEAD— passes.Full Release Validation parent 36979284285 reproduced the original drift. Landing changes the candidate SHA, so a fresh complete parent is required.