Skip to content

chore(ui): refresh 2026.9.8 control ui locales - #163409

Merged
RomneyDa merged 1 commit into
release/2026.9.8from
fix/release98-locale-only
Oct 2, 2026
Merged

RomneyDa merged 1 commit into
release/2026.9.8from
fix/release98-locale-only

Conversation

@roboclaw-bot

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The 2026.9.8 release branch changed one Control UI silent-reply help string after its last locale refresh. Release preflight therefore rejected the candidate's generated locale metadata.

Solution

Import the reviewed per-locale translation-memory replacement from #162942 and regenerate metadata against the release branch's own 10,083-key catalog. This PR intentionally contains only owner-generated locale artifacts; source repairs remain in #163392.

Evidence

  • pnpm ui:i18n:check — all 20 locales clean, zero fallback keys.
  • git diff --check 6bebbac77c70bb6a481a02d8da1739beef467c64...HEAD — passes.
  • The combined repair received fresh Codex autoreview through P1 with no actionable findings; this PR is the generated-artifact subset required by CI ownership.

Full Release Validation parent 36979284285 reproduced the original drift. Landing changes the candidate SHA, so a fresh complete parent is required.

Import the reviewed silent-reply help translations from #162942 and regenerate metadata against the release candidate catalog.

Co-authored-by: RomneyDa <6581799+RomneyDa@users.noreply.github.com>

Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
@clawsweeper

clawsweeper Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@roboclaw-bot
roboclaw-bot marked this pull request as ready for review October 2, 2026 09:00
@clawsweeper clawsweeper Bot added P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 2, 2026
@clawsweeper

clawsweeper Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Codex review: blocked before merge. Reviewed October 2, 2026, 5:06 AM ET / 09:06 UTC.

ClawSweeper review

What this changes

Refreshes translations for one silent-reply help string across 20 Control UI locales and regenerates metadata for the 2026.9.8 release catalog.

Merge readiness

⛔ Blocked before merge - 1 item remains

Keep open: this is a focused release-branch repair, and the merged main-branch locale refresh does not replace its release-specific catalog metadata. No actionable introduced defect was found.

Priority: P2
Reviewed head: d477a74e3706692612f3bcf5dbc09f501937747a

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused generated-artifact repair with consistent source keys, preserved catalog structure, and relevant reported validation.
Proof confidence 🌊 off-meta tidepool Not applicable: This bot-authored generated-artifact repair is exempt from external-contributor runtime proof. The reported production locale-check entrypoint covers catalog synchronization; no browser behavior was exercised by this reviewer. Translation-memory fields and user-state contracts remain unchanged.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: This bot-authored generated-artifact repair is exempt from external-contributor runtime proof. The reported production locale-check entrypoint covers catalog synchronization; no browser behavior was exercised by this reviewer. Translation-memory fields and user-state contracts remain unchanged.
Evidence reviewed 8 items Pinned introduced change: The introduced delta replaces one source-specific silent-reply translation row per locale and changes generation timestamps and catalog hashes. All 20 added rows reference the same new English help text; no executable code, settings, dependencies, or translation-memory format changes are introduced.
Release catalog remains distinct: The proposed metadata retains 10,083 translated keys and empty fallback lists. Fetched main has a different source hash and 10,207 keys; v2026.9.7 contains the older release catalog hash. Main's refreshed metadata therefore cannot substitute for this release-branch repair.
Latest release comparison: The latest supplied release, v2026.9.7, records source hash 06a14fc126d9df89079db0dd8d60adfc50a4c636169c74f1fa0032c22cc9e040, rather than this PR's release-candidate hash.
Findings None None.
Security None None.

How this fits together

Control UI localization combines English UI copy and configuration help with generated translation memory. The build materializes localized catalogs, while release verification checks their completeness and source hashes.

flowchart LR
  A[English UI copy] --> C[Release source catalog]
  B[Configuration help] --> C
  C --> E[Locale materialization]
  D[Translation memory] --> E
  E --> F[Localized Control UI]
  C --> G[Release locale verification]
  D --> G
Loading

Before merge

  • Add data-model compatibility proof - Confirm migration or upgrade compatibility proof before merge.
Agent review details

Security

None.

PR surface

Source 0. Total 0 across 41 files.

View PR surface stats
Area Files Added Removed Net
Source 41 61 61 0
Tests 0 0 0 0
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 41 61 61 0

Review metrics

None.

Stored data model

Persistent data-model change detected: serialized state: ui/src/i18n/.i18n/ko.tm.jsonl, serialized state: ui/src/i18n/.i18n/th.tm.jsonl, unknown-data-model-change: ui/src/i18n/.i18n/ko.tm.jsonl, unknown-data-model-change: ui/src/i18n/.i18n/th.tm.jsonl. Confirm migration or upgrade compatibility proof before merge.

Technical review

Best possible solution:

Keep release-specific locale artifacts synchronized through the existing generator and strict locale verification.

Do we have a high-confidence way to reproduce the issue?

Not applicable to a current-main runtime bug: the reported failure is release-catalog drift, and the differing source hashes are visible in the inspected artifacts.

Is this the best way to solve the issue?

Yes. Reusing reviewed translations and regenerating release-specific metadata preserves the existing localization owner without duplicating implementation.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 6000ebd389bf.

Labels

Label changes:

  • add P2: This bounded artifact repair addresses a reported locale-verification failure in the release candidate.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This bot-authored generated-artifact repair is exempt from external-contributor runtime proof. The reported production locale-check entrypoint covers catalog synchronization; no browser behavior was exercised by this reviewer. Translation-memory fields and user-state contracts remain unchanged.

Label justifications:

  • P2: This bounded artifact repair addresses a reported locale-verification failure in the release candidate.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This bot-authored generated-artifact repair is exempt from external-contributor runtime proof. The reported production locale-check entrypoint covers catalog synchronization; no browser behavior was exercised by this reviewer. Translation-memory fields and user-state contracts remain unchanged.

Evidence

What I checked:

  • Pinned introduced change: The introduced delta replaces one source-specific silent-reply translation row per locale and changes generation timestamps and catalog hashes. All 20 added rows reference the same new English help text; no executable code, settings, dependencies, or translation-memory format changes are introduced. (ui/src/i18n/.i18n/de.tm.jsonl:3122, d477a74e3706)
  • Release catalog remains distinct: The proposed metadata retains 10,083 translated keys and empty fallback lists. Fetched main has a different source hash and 10,207 keys; v2026.9.7 contains the older release catalog hash. Main's refreshed metadata therefore cannot substitute for this release-branch repair. (ui/src/i18n/.i18n/de.meta.json:5, 6000ebd389bf)
  • Latest release comparison: The latest supplied release, v2026.9.7, records source hash 06a14fc126d9df89079db0dd8d60adfc50a4c636169c74f1fa0032c22cc9e040, rather than this PR's release-candidate hash. (ui/src/i18n/.i18n/de.meta.json:5, c074824a27c9)
  • Generated artifact owner: The full root and UI policies were read. UI policy identifies translation memory as canonical generated input, supports authenticated release repair, and separates generated artifacts from source changes. This PR follows that separation. (ui/AGENTS.md:54, d477a74e3706)
  • Build and compatibility boundary: The existing materializer admits translations only when their segment and text hash match the current source catalog. Vite consumes that materialized catalog through existing locale adapters. The patch preserves this format and does not alter stored user state or locale preferences. (scripts/lib/control-ui-i18n-catalog-values.ts:99, d477a74e3706)
  • Merged translation source and companion repair: GitHub confirms chore(ui): refresh control ui locales #162942 merged into main as e13363e. The captured body identifies it as the translation source and identifies fix(release): qualify npm 11 locks and locale catalog #163392 as the separate open source repair for the same release campaign. Neither makes this release-specific artifact PR redundant. (e13363e288d1)

Likely related people:

  • husodrn46: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
  • vincentkoc: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@RomneyDa
RomneyDa merged commit 0760906 into release/2026.9.8 Oct 2, 2026
118 of 119 checks passed
@RomneyDa
RomneyDa deleted the fix/release98-locale-only branch October 2, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: S status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants