fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655) by clawsweeper[bot] · Pull Request #94784 · openclaw/openclaw

clawsweeper · 2026-06-19T04:10:16Z

Makes #94659 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

Source

Replacement for #94659 because the source branch could not be updated.

Original contributor: @ZengWen-DT.

clawsweeper · 2026-06-19T04:11:17Z

Codex review: needs maintainer review before merge. Reviewed June 21, 2026, 5:38 PM ET / 21:38 UTC.

Summary
The PR moves manual-only cron command/shell prompt advisories out of the auto-repair preview, adds cron regression tests, and expands CI timing helper retries for transient GitHub API failures.

PR surface: Source +66, Tests +156, Other +6. Total +228 across 8 files.

Reproducibility: yes. at source level. Current main and v2026.6.9 route unresolved shell/process cron prompt jobs into the legacy issue preview and then append the shared openclaw doctor --fix repair note.

Review metrics: 2 noteworthy metrics.

Manual Cron Advisories: 2 advisory classes split. The PR changes operator-facing doctor guidance for supported shell-prompt jobs and restricted command-prompt jobs, which is the main maintainer decision before merge.
CI Retry Classifier: 4 retryable cases added, 1 auth failure preserved. The script change broadens automation retry behavior while the focused test keeps authorization failures non-retryable.

Stored data model
Persistent data-model change detected: migration/backfill/repair: src/commands/doctor/cron/index.test.ts, migration/backfill/repair: src/commands/doctor/cron/index.ts, migration/backfill/repair: src/commands/doctor/cron/payload-migration.ts, migration/backfill/repair: src/commands/doctor/cron/repair-plan.ts, migration/backfill/repair: src/commands/doctor/cron/store-migration.ts, unknown-data-model-change: src/commands/doctor/cron/index.test.ts, and 2 more. Confirm migration or upgrade compatibility proof before merge.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #94655
Summary: This PR is an active credited replacement candidate for the canonical doctor cron repair-hint issue; sibling PRs target the same or overlapping doctor output problem.

Members:

canonical: doctor: cron store issues finding persists after --fix and references migrated jobs.json #94655 - The issue reports the persistent doctor cron repair hint and stale logical jobs.json wording this PR fixes.
superseded: fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655) #94659 - The PR body says this branch replaces the closed source PR because that source branch could not be updated.
same_root_cause: fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655) #94886 - The open sibling targets the same doctor cron repair-hint behavior, but its current labels/review state make this PR the safer active landing path.
superseded: #94655: doctor: cron store issues finding persists after --fix and references migrated jobs.json #94668 - The closed unmerged PR attempted the same doctor cron output problem and is no longer an active landing path.
partial_overlap: fix(doctor): improve labels and manual instructions for cron store issues [AI-assisted] #94920 - The closed PR overlapped the doctor cron wording problem while changing adjacent labels and manual instructions.
1 more in the report.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Risk before merge

[P1] The restricted command-prompt advisory names granting shell/process tool access as a valid operator action, so maintainers should approve that security-sensitive guidance or narrow it before merge.
[P1] Open sibling fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655) #94886 targets the same doctor cron bug and should be cleaned up after one fix lands.
[P1] The PR is paused with clawsweeper:human-review, so the automerge lane needs maintainer approval before continuing.

Maintainer options:

Approve Or Tighten Shell-Access Guidance (recommended)
A maintainer should either approve the grant-access wording as intentional operator guidance or change the advisory to recommend command-cron conversion only before merge.
Accept Current Advisory
Maintainers can intentionally accept the current wording if they agree it is accurate and sufficiently explicit for this doctor path.
Pause For A Different Candidate
If maintainers prefer another implementation, keep this PR paused and make a sibling PR canonical only after it is proof-positive and review-ready.

Next step before merge

[P2] Maintainer review is needed because the code path has no narrow repair finding, but the advisory's shell/process tool-access guidance is security-sensitive and the PR is paused for human approval.

Security
Cleared: No concrete code or supply-chain security regression was found; the shell/process access wording remains a maintainer merge-risk decision.

Review details

Best possible solution:

Land this credited replacement after maintainer wording approval or tightening, then close #94655 and supersede overlapping duplicate PRs.

Do we have a high-confidence way to reproduce the issue?

Yes, at source level. Current main and v2026.6.9 route unresolved shell/process cron prompt jobs into the legacy issue preview and then append the shared openclaw doctor --fix repair note.

Is this the best way to solve the issue?

Yes, with maintainer wording approval. Splitting manual-only cron advisories from formatLegacyIssuePreview is the narrow owner-boundary fix and avoids changing cron execution, storage config, or migration behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 108d6d7eca00.

Label changes

Label justifications:

P2: This is a normal-priority doctor CLI diagnostic bug with misleading operator guidance and no reported cron runtime failure.
merge-risk: 🚨 security-boundary: The doctor advisory discusses granting shell/process tool access for restricted cron prompts, so maintainer approval is needed before merge.
rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (terminal): The credited source PR includes terminal output from a real doctor CLI run against an isolated SQLite-backed OpenClaw state, and this replacement preserves that behavior with additional regression coverage.
proof: sufficient: Contributor real behavior proof is sufficient. The credited source PR includes terminal output from a real doctor CLI run against an isolated SQLite-backed OpenClaw state, and this replacement preserves that behavior with additional regression coverage.

Evidence reviewed

PR surface:

Source +66, Tests +156, Other +6. Total +228 across 8 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	4	99	33	+66
Tests	3	156	0	+156
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	1	7	1	+6
Total	8	262	34	+228

What I checked:

Current main still affected: Current main passes unresolved shell/process prompt jobs into formatLegacyIssuePreview and then appends the shared openclaw doctor --fix repair instruction to the same Cron note. (src/commands/doctor/cron/index.ts:339, 108d6d7eca00)
Current main manual advisory path: The unresolved shell/process manual-conversion warning is still emitted inside the legacy issue preview formatter on current main. (src/commands/doctor/cron/repair-plan.ts:61, 108d6d7eca00)
Latest release still affected: v2026.6.9 contains the same unresolved prompt preview wiring and shared doctor repair instruction, so the PR is not obsolete in the latest shipped release. (src/commands/doctor/cron/index.ts:339, c645ec4555c0)
PR head separates advisory-only jobs: PR head emits command-prompt and shell-prompt cron advisories before formatLegacyIssuePreview(normalized.issues), allowing advisory-only jobs to avoid the shared repair note. (src/commands/doctor/cron/index.ts:341, f427d02a96ab)
PR head distinguishes restricted prompts: PR head separates restricted command prompts from supported shell-tool prompts and names command-cron recreation or explicit shell/process tool access as operator choices. (src/commands/doctor/cron/repair-plan.ts:19, f427d02a96ab)
Regression coverage: PR-head tests cover supported shell-tool prompt jobs and restricted command prompts, asserting no doctor --fix repair note is shown and the jobs are not rewritten. (src/commands/doctor/cron/index.test.ts:603, f427d02a96ab)

Likely related people:

mbelinky: The command-cron support commit added the doctor-side command payload migration and related cron advisory surface this PR changes. (role: introduced related behavior; confidence: high; commits: b8adc11977ab; files: src/commands/doctor/cron/payload-migration.ts, src/commands/doctor/cron/repair-plan.ts, src/commands/doctor/cron/store-migration.ts)
steipete: The SQLite cron persistence commit made cron.store a logical import key rather than the live cron store after migration, matching part of the reported stale-path confusion. (role: SQLite cron migration contributor; confidence: high; commits: 005da57957c9; files: src/cron/store.ts, src/commands/doctor/cron/index.ts, docs/automation/cron-jobs.md)
liuhao1024: Recent merged work adjusted false-positive legacy cron store doctor wording in the same index/test surface. (role: recent adjacent contributor; confidence: medium; commits: 274b7b1d9f5d; files: src/commands/doctor/cron/index.ts, src/commands/doctor/cron/index.test.ts)
MonkeyLeeT: Recent legacy cron store auto-migration work touched the same doctor cron repair orchestration path. (role: recent migration contributor; confidence: medium; commits: 21aa297434e4; files: src/commands/doctor/cron/index.ts)
altaywtf: Assigned to the PR and authored the latest head commit that splits restricted command-prompt advisories from supported shell-prompt advisories. (role: current follow-up owner; confidence: medium; commits: f427d02a96ab; files: src/commands/doctor/cron/index.ts, src/commands/doctor/cron/repair-plan.ts, src/commands/doctor/cron/payload-migration.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

clawsweeper · 2026-06-19T04:15:36Z

🦞✅
Maintainer-approved ClawSweeper automerge is complete.

Approver: altaywtf
Head: 0d71970a16e2
Merge status: merged by ClawSweeper automerge
Merged at: 2026-06-22T10:42:22Z
Merge commit: 6f17c4cc6d23

What merged:

Merged fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (doctor: cron store issues finding persists after --fix and references migrated jobs.json #94655) after ClawSweeper review.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(doctor): stop promising --fix for working isolated shell-prompt c…

The automerge loop is complete.

Automerge progress:

2026-06-19 09:21:33 UTC repair finished c6f44352dc32 (pushed) in 21m 35s Run: https://github.com/openclaw/clawsweeper/actions/runs/27814184442 repair_contributor_branch

2026-06-19 11:29:42 UTC review queued c6f44352dc32 (queued)

2026-06-19 11:37:01 UTC review passed c6f44352dc32 (structured ClawSweeper verdict: pass (sha=c6f44352dc328e9619ac4546d3ed00c978330...)

2026-06-19 11:29:22 UTC repair queued c6f44352dc32 (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193

2026-06-19 12:41:17 UTC repair started (running) in 1s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 automerge-openclaw-openclaw-94784

2026-06-19 12:41:35 UTC validation plan (passed) in 19s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 pnpm check:changed; pnpm lint; pnpm check:test-types

2026-06-19 12:41:51 UTC Codex write preflight (passed) in 35s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 danger-full-access

2026-06-19 12:50:53 UTC Codex edit 1 2ece13b5fc06 (complete) in 9m 38s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 exit 0

2026-06-19 12:53:15 UTC validation and review 1 4b0d9af11e02 (base moved) in 11m 59s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 rebased

2026-06-19 12:53:20 UTC repair completed 4b0d9af11e02 (branch updated) in 12m 5s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 initial automerge rebase is delegated to Codex repair

2026-06-19 12:53:19 UTC review queued 4b0d9af11e02 (after repair)

2026-06-19 13:03:24 UTC automerge wait 4b0d9af11e02 (waiting) in 22m 8s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 waiting for GitHub checks: preflight:QUEUED, Security High (core-auth-secrets):QUEUED, Select Critical Quality shards:QUEUED, Scan changed paths (precise):QUEU...

2026-06-19 13:03:25 UTC repair finished 4b0d9af11e02 (pushed) in 22m 10s Run: https://github.com/openclaw/clawsweeper/actions/runs/27823050193 repair_contributor_branch

2026-06-19 22:23:33 UTC review passed fda0478770a7 (structured ClawSweeper verdict: pass (sha=fda0478770a75c6b832fd29f528c351ec03e1...)

2026-06-19 22:53:09 UTC review queued cf6c31b235e8 (queued)

2026-06-22 10:42:24 UTC merged 0d71970a16e2 (merged by ClawSweeper automerge)

altaywtf · 2026-06-19T23:32:46Z

@clawsweeper review

clawsweeper · 2026-06-19T23:32:49Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

clawsweeper · 2026-06-19T23:36:40Z

🦞✅
ClawSweeper is pausing this repair loop for human review.

Source: clawsweeper[bot]
Reason: - [P2] Maintainer review is needed because the code path has no narrow repair finding, but the advisory's shell/process tool-access guidance is security-sensitive and the PR is paused for human approval.; Cleared: No concrete code or supply-chain security regression was found; the shell/process access wording remains a maintainer merge-risk decision. (sha=f427d02a96ab82c145a436f180027385b59dc9a2)

Why human review is needed:
This item has security-sensitive risk. ClawSweeper is pausing instead of making an autonomous change that could affect trust, credentials, permissions, or exposure.

What the maintainer can do as a next step:
If the maintainer accepts the current risk and wants ClawSweeper to continue merge gates, comment @clawsweeper approve. If the security-sensitive detail still needs changes, describe the safe path or push the fix, then comment @clawsweeper automerge. If the risk should not be automated, keep the PR paused for manual review or comment @clawsweeper stop.

I added clawsweeper:human-review and left the final call with a maintainer.

altaywtf · 2026-06-22T10:23:03Z

@clawsweeper review

…ron jobs (#94655) Co-authored-by: ZengWen-DT <290981215+ZengWen-DT@users.noreply.github.com>

…ron jobs (#94655)

altaywtf · 2026-06-22T10:29:41Z

@clawsweeper review

clawsweeper · 2026-06-22T10:29:44Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

altaywtf · 2026-06-22T10:41:08Z

@clawsweeper approve

clawsweeper Bot mentioned this pull request Jun 19, 2026

fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655) #94659

Closed

openclaw-barnacle Bot added the size: S label Jun 19, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-94659 branch from c4e80ce to a844977 Compare June 19, 2026 04:40

This comment has been minimized.

Sign in to view

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-94659 branch from a844977 to 4687f0d Compare June 19, 2026 04:58

github-actions Bot mentioned this pull request Jun 19, 2026

🦞 OpenClaw 生态日报 2026-06-19 96loveslife/big_model_radar#34

Open

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-94659 branch 4 times, most recently from fbad6d2 to 1bfa2b2 Compare June 19, 2026 06:54

clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Jun 19, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-94659 branch 2 times, most recently from 7454a37 to d3e526d Compare June 19, 2026 08:12

clawsweeper Bot mentioned this pull request Jun 19, 2026

fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655) #94886

Closed

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-94659 branch from d3e526d to c6f4435 Compare June 19, 2026 09:11

clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Jun 19, 2026

This was referenced Jun 19, 2026

fix(doctor): improve labels and manual instructions for cron store issues [AI-assisted] #94920

Closed

fix(doctor): stop promising --fix for manual-only cron shell/process advisories #94934

Closed

openclaw-barnacle Bot added extensions: mistral extensions: ollama extensions: openrouter extensions: policy plugin: workboard extensions: parallel size: XL and removed size: M labels Jun 19, 2026

altaywtf force-pushed the clawsweeper/automerge-openclaw-openclaw-94659 branch from d94e3a6 to f427d02 Compare June 19, 2026 23:31

openclaw-barnacle Bot removed docs Improvements or additions to documentation channel: discord Channel integration: discord channel: googlechat Channel integration: googlechat labels Jun 19, 2026

clawsweeper Bot and others added 11 commits June 22, 2026 13:29

fix(doctor): stop promising --fix for working isolated shell-prompt c…

df271c4

…ron jobs (#94655) Co-authored-by: ZengWen-DT <290981215+ZengWen-DT@users.noreply.github.com>

fix(doctor): stop promising --fix for working isolated shell-prompt c…

71037a8

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

1cce329

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

6d45f7f

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

d35d943

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

bc92fad

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

6221289

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

88b1593

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

8eaddda

…ron jobs (#94655)

fix(doctor): stop promising --fix for working isolated shell-prompt c…

a8b5afc

…ron jobs (#94655)

fix(doctor): split restricted cron prompt advisory

0d71970

Navigation Menu

Uh oh!

fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655) - #94784

fix(doctor): stop promising --fix for working isolated shell-prompt cron jobs (#94655)#94784
clawsweeper[bot] merged 11 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-94659

clawsweeper Bot commented Jun 19, 2026

Uh oh!

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

altaywtf commented Jun 19, 2026

Uh oh!

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

altaywtf commented Jun 22, 2026

Uh oh!

altaywtf commented Jun 22, 2026

Uh oh!

clawsweeper Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

altaywtf commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented Jun 19, 2026

Source

Uh oh!

clawsweeper Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

altaywtf commented Jun 19, 2026

Uh oh!

clawsweeper Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

altaywtf commented Jun 22, 2026

Uh oh!

altaywtf commented Jun 22, 2026

Uh oh!

clawsweeper Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

altaywtf commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

clawsweeper Bot commented Jun 19, 2026 •

edited

Loading

clawsweeper Bot commented Jun 22, 2026 •

edited

Loading