fix(active-memory): exclude dreaming-narrative session keys from eligibility gate - #95721
Merged
Merged
Conversation
vincentkoc
force-pushed
the
maint/recover-pr-93168-active-memory-dreaming
branch
2 times, most recently
from
June 22, 2026 09:35
e09763b to
f0b0e64
Compare
…ractive eligibility gate Dreaming-narrative cron session keys (agent:<agent>:dreaming-narrative-*) share trigger="user" with conversational sessions, so the isEligibleInteractiveSession gate let them through. Each accepted invocation pays the full AM cold-start cost inside a hardcoded 45000ms command-lane budget and reliably times out. Fixes #78500 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…o canonical forms Replace the broad substring match with a regex that only excludes canonical dreaming-narrative session keys (bare or agent-prefixed) with known phase suffixes (light, rem, deep). Real chat session IDs that happen to contain "dreaming-narrative" (e.g. telegram:group:dreaming-narrative-room) remain eligible. Also add a regression test proving non-canonical keys pass the eligibility gate.
vincentkoc
force-pushed
the
maint/recover-pr-93168-active-memory-dreaming
branch
from
June 22, 2026 09:46
f0b0e64 to
fc8717e
Compare
Member
Author
|
Merged via squash.
Thanks @vincentkoc! |
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 23, 2026
…ibility gate (openclaw#95721) Merged via squash. Prepared head SHA: fc8717e Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com> Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com> Reviewed-by: @vincentkoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes #78500.
This restores the reviewed active-memory fix from #93168 after the contributor fork branch became unavailable during maintainer sync. Dreaming-narrative cron session keys should not be eligible for active-memory recall and consume the nightly cron lane budget.
Why This Change Was Made
The eligibility guard now rejects canonical dreaming-narrative session keys while preserving real chat/session keys that only contain the same phrase as a substring. The branch preserves the original reviewed diff and commit authors from #93168, including the maintainer fix for sessionId-only contexts, rebased onto current
main.User Impact
Nightly dreaming-narrative cron windows avoid active-memory cold-start work, reducing 45s lane timeout risk without suppressing unrelated interactive chats.
Evidence
tbx_01kvq31d9z1hc09q946wr8nj99:node scripts/run-vitest.mjs extensions/active-memory/index.test.tspassed, 1 file / 152 tests.