Skip to content

Simplify color mode button labels - #95837

Merged
hannesrudolph merged 2 commits into
openclaw:mainfrom
SannidhyaSah:ui/color-mode-button-labels
Jun 22, 2026
Merged

hannesrudolph merged 2 commits into
openclaw:mainfrom
SannidhyaSah:ui/color-mode-button-labels

Conversation

@SannidhyaSah

@SannidhyaSah SannidhyaSah commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

The Control UI theme mode buttons repeated the surrounding group label in each tooltip and accessible button label, producing labels like Color mode: Light even though the button group is already labeled Color mode.

Why This Change Was Made

This changes each theme mode button to expose only the differentiating mode name: System, Light, or Dark. The surrounding group keeps the broader Color mode label, so the UI still has the same context without repeating it on every button.

The now-unused common.colorModeOption translation key was removed and the locale bundles were regenerated.

User Impact

Users see shorter hover tooltips for the theme mode controls, and assistive technology gets less repetitive button labels while retaining the group context.

Evidence

  • pnpm ui:build
  • pnpm test:ui
  • git diff --check
  • Screenshot proof captured locally:
    Before:
image

After:

image

@hannesrudolph hannesrudolph self-assigned this Jun 22, 2026
@hannesrudolph
hannesrudolph requested a review from a team as a code owner June 22, 2026 23:20
@github-actions github-actions Bot added the dependencies-changed PR changes dependency-related files label Jun 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Guard

This PR changes dependency-related files. Maintainers should confirm these changes are intentional.

Changed files:

  • extensions/qa-lab/package.json
  • pnpm-lock.yaml
  • pnpm-workspace.yaml

Maintainer follow-up:

  • Review whether the dependency changes are intentional.
  • Inspect resolved package deltas when lockfile, shrinkwrap, or workspace dependency policy changes are present.
  • Treat package-lock.json and npm-shrinkwrap.json diffs as security-review surfaces.
  • Run pnpm deps:changes:report -- --base-ref origin/main --markdown /tmp/dependency-changes.md --json /tmp/dependency-changes.json locally for detailed release-style evidence.

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation channel: imessage Channel integration: imessage channel: telegram Channel integration: telegram app: android App: android app: ios App: ios app: macos App: macos gateway Gateway runtime extensions: memory-core Extension: memory-core cli CLI command changes scripts Repository scripts commands Command implementations agents Agent runtime and tooling channel: feishu Channel integration: feishu extensions: minimax channel: qqbot extensions: qa-lab extensions: google extensions: opencode-go extensions: openrouter labels Jun 22, 2026
@hannesrudolph
hannesrudolph merged commit 3c06770 into openclaw:main Jun 22, 2026
10 checks passed
@hannesrudolph

Copy link
Copy Markdown
Member

Merged via squash.

Thanks @SannidhyaSah!

@github-actions

Copy link
Copy Markdown
Contributor

Dependency graph changes are blocked

OpenClaw does not accept dependency graph changes through PRs unless a repository admin or security explicitly authorizes the current head SHA. Dependency updates are generated internally by maintainers so external PRs cannot change the resolved graph.

Detected dependency graph changes:

  • pnpm-lock.yaml changed.
  • extensions/qa-lab/package.json changed devDependencies.

Auto-scrub was not attempted because this PR changes package manifest dependency graph fields:

  • extensions/qa-lab/package.json changed devDependencies.

Dependency graph changes must be reviewed by security or handled by maintainers internally. Please remove lockfile changes manually if they are not needed.

To remove lockfile changes, restore them from the target branch:

git fetch origin
git checkout 'origin/main' -- 'pnpm-lock.yaml'
git commit -m 'chore: remove dependency lockfile change'
git push

If this PR intentionally needs a dependency graph change, ask a repository admin or member of @openclaw/openclaw-secops to comment:

/allow-dependencies-change

The action will approve the current head SHA (3da7299026ff6c25c35c7910dc1da86251788535) when it reruns. A later push requires a fresh approval.

@SannidhyaSah
SannidhyaSah deleted the ui/color-mode-button-labels branch June 23, 2026 04:21
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 23, 2026
Merged via squash.

Prepared head SHA: 3da7299
Co-authored-by: SannidhyaSah <186946675+SannidhyaSah@users.noreply.github.com>
Co-authored-by: hannesrudolph <49103247+hannesrudolph@users.noreply.github.com>
Reviewed-by: @hannesrudolph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling app: android App: android app: ios App: ios app: macos App: macos app: web-ui App: web-ui channel: feishu Channel integration: feishu channel: imessage Channel integration: imessage channel: qqbot channel: telegram Channel integration: telegram cli CLI command changes commands Command implementations dependencies-changed PR changes dependency-related files docs Improvements or additions to documentation extensions: google extensions: memory-core Extension: memory-core extensions: minimax extensions: opencode-go extensions: openrouter extensions: qa-lab gateway Gateway runtime scripts Repository scripts size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants