fix(ci): require QA live evidence artifacts - #95952
Merged
Merged
Conversation
vincentkoc
force-pushed
the
ops/qa-live-artifact-evidence
branch
from
June 23, 2026 03:55
3fb0e05 to
473986a
Compare
vincentkoc
marked this pull request as ready for review
June 23, 2026 03:58
Member
Author
|
Land-ready proof for
Known local gap: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
QA live transport workflows are evidence-producing gates, but their artifact uploads used
if-no-files-found: warn. That means a lane could report success without durable QA evidence if the expected output directory was empty or not written.Why This Change Was Made
if-no-files-found: errorUser Impact
Nightly and manual QA live runs fail loudly when their evidence bundle is missing instead of producing a green run with no useful artifacts.
Evidence
.github/workflows/qa-live-transports-convex.yml: all QA live upload steps ran withif: always()but accepted missing files withwarngo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.11 .github/workflows/qa-live-transports-convex.ymlgit diff --checknode scripts/crabbox-wrapper.mjs job run testbox-changedfor473986a0d959df3ef8dcb82c23b9df2ac977ba70(tbx_01kvs9wtzg1zv4arkfytc3a8cr; wrapper command exited 0; https://github.com/openclaw/openclaw/actions/runs/28001043651)codex review --base origin/main: no actionable regressions after the guard job-id fixKnown proof gap
node scripts/run-vitest.mjs test/scripts/package-acceptance-workflow.test.tscould not run locally because this sparse Codex worktree has nonode_modules; the Testbox changed gate covered the touched test lane remotely.