Skip to content

test(qa): expand docker lane adapter - #97937

Merged
RomneyDa merged 2 commits into
mainfrom
dallin/qa-real-e2e-step1-foundation
Jun 30, 2026
Merged

RomneyDa merged 2 commits into
mainfrom
dallin/qa-real-e2e-step1-foundation

Conversation

@RomneyDa

@RomneyDa RomneyDa commented Jun 29, 2026

Copy link
Copy Markdown
Member

What Problem This Solves

Keeps step 1 of the real-E2E QA cleanup focused on QA-owned Docker lane dispatch without leaving unused QA helper modules behind.

The Docker-backed scenarios were still routing through scripts/qa/docker-e2e-lane.ts. This PR moves that adapter into QA Lab runtime code so the scenario executable lives with the QA fixtures, while the existing heavy Docker shell scripts remain the thin lane entrypoints they already are.

Why This Change Was Made

  • Moves the Docker lane adapter from scripts/qa/docker-e2e-lane.ts to test/e2e/qa-lab/runtime/docker-e2e-lane.ts.
  • Updates existing Docker-backed QA scenarios to execute the QA Lab runtime adapter path.
  • Expands the adapter with existing Docker E2E lane names needed by upcoming QA scenario wrappers.
  • Adds --list and --help to the adapter so scenario wrappers can discover/validate lane names without duplicating the map.
  • Removes the unused qa-transport-scenarios helper and its unit test instead of preserving an unused re-export/helper surface.
  • Removes the broad QA transport helper re-export from live-transport-scenarios.ts; live transport code continues to use the existing SDK seam directly.

User Impact

No taxonomy IDs, product runtime behavior, or QA scenario coverage claims change. This is QA infrastructure cleanup that keeps script-to-QA migrations grounded in QA-owned executables without adding unused helper APIs.

Evidence

  • node --import tsx test/e2e/qa-lab/runtime/docker-e2e-lane.ts --list
  • node --import tsx test/e2e/qa-lab/runtime/docker-e2e-lane.ts --help
  • node scripts/run-vitest.mjs extensions/qa-lab/src/scenario-catalog.test.ts --reporter=verbose
  • pnpm deadcode:unused-files
  • pnpm deadcode:dependencies
  • pnpm check:test-types
  • pnpm exec oxfmt --check test/e2e/qa-lab/runtime/docker-e2e-lane.ts qa/scenarios/runtime/docker-gateway-network.yaml qa/scenarios/plugins/clawhub-marketplace-list.yaml
  • git diff --check
  • .agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main clean

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts docker Docker and sandbox tooling extensions: qa-lab size: L maintainer Maintainer-authored PR labels Jun 29, 2026
@clawsweeper

clawsweeper Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed June 29, 2026, 8:02 PM ET / 00:02 UTC.

Summary
The PR moves the QA Docker E2E lane adapter into QA Lab runtime, expands lane registry discovery, repoints Docker-backed QA scenario YAML, and removes an unused QA transport helper.

PR surface: Source -170, Tests +142, Other -90. Total -118 across 19 files.

Reproducibility: not applicable. as a bug report. The reviewable behavior is source-checkable: current main lacks the new discovery modes and aliases, while the PR head adds them and repoints Docker-backed YAML scenarios to the moved adapter.

Review metrics: 1 noteworthy metric.

  • Docker lane dispatch surface: 6 aliases added, 2 discovery modes added, 0 aliases removed. The adapter map and discovery flags are internal QA automation contract changes that maintainers should notice before merge.

Stored data model
Persistent data-model change detected: migration/backfill/repair: scripts/qa/docker-e2e-lane.ts, migration/backfill/repair: test/e2e/qa-lab/runtime/docker-e2e-lane.fixture.test.ts, migration/backfill/repair: test/e2e/qa-lab/runtime/docker-e2e-lane.fixture.ts. Confirm migration or upgrade compatibility proof before merge.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Risk before merge

  • [P1] The moved adapter and added aliases are an internal automation dispatch contract; a stale or wrong script mapping could send QA scenario wrappers to the wrong Docker lane even when ordinary type checks pass.

Maintainer options:

  1. Land After Exact-Head QA Checks (recommended)
    Maintainers can accept the bounded automation risk once the current-head lane registry and CI/QA checks are green.
  2. Require One Adapter Smoke
    Ask for current-head terminal proof of --list, --help, and one newly added lane resolving before merge if maintainers want direct dispatch proof.

Next step before merge

  • [P2] No repair lane is needed; the remaining action is maintainer review of the maintainer-labeled internal QA dispatch change and exact-head checks.

Security
Cleared: Cleared: the diff changes repo-local QA adapter code, tests, and YAML mappings only; it does not alter dependencies, workflows, lockfiles, secrets, publishing, or downloaded-code sources.

Review details

Best possible solution:

Land after maintainer review confirms the lane registry and discovery contract and exact-head CI/QA evidence for the moved adapter.

Do we have a high-confidence way to reproduce the issue?

Not applicable as a bug report. The reviewable behavior is source-checkable: current main lacks the new discovery modes and aliases, while the PR head adds them and repoints Docker-backed YAML scenarios to the moved adapter.

Is this the best way to solve the issue?

Yes. Moving the adapter under QA Lab runtime while keeping heavy Docker shell scripts as thin entrypoints is the narrow owner-boundary cleanup, and deleting the unused qa-transport helper avoids preserving a dead private surface.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 18b2ff683fd3.

Label changes

Label justifications:

  • P2: This is bounded QA infrastructure with limited product-runtime blast radius but meaningful maintainer automation impact.
  • merge-risk: 🚨 automation: The diff changes the script-backed QA Docker lane adapter, scenario dispatch path, and lane discovery behavior used by QA automation.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: Not applicable: this is a member-authored, maintainer-labeled internal QA infrastructure PR, so the external-contributor real behavior proof gate does not apply.
Evidence reviewed

PR surface:

Source -170, Tests +142, Other -90. Total -118 across 19 files.

View PR surface stats
Area Files Added Removed Net
Source 2 0 170 -170
Tests 4 281 139 +142
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 13 12 102 -90
Total 19 293 411 -118

What I checked:

Likely related people:

  • RomneyDa: Recent merged history added the ClawHub QA Docker scenario mapping and the QA transport scenario helper that this PR narrows or removes. (role: recent area contributor; confidence: high; commits: beab0ecb02dd, 843ad143647e; files: qa/scenarios/plugins/clawhub-marketplace-list.yaml, extensions/qa-lab/src/qa-transport-scenarios.ts, extensions/qa-lab/src/live-transports/shared/live-transport-scenarios.ts)
  • Harjoth Khara: Current-main blame attributes the original scripts/qa Docker lane adapter scaffold and dispatch logic to commit 355c43f. (role: introduced wrapper scaffold; confidence: medium; commits: 355c43fe0c9e; files: scripts/qa/docker-e2e-lane.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. P2 Normal backlog priority with limited blast radius. merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. labels Jun 29, 2026
@RomneyDa
RomneyDa force-pushed the dallin/qa-real-e2e-step1-foundation branch from 5f0daf2 to 88d7628 Compare June 29, 2026 22:41
@RomneyDa

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@RomneyDa
RomneyDa force-pushed the dallin/qa-real-e2e-step1-foundation branch from 88d7628 to b1a083b Compare June 29, 2026 22:49
@RomneyDa

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@clawsweeper clawsweeper Bot added the merge-risk: 🚨 availability 🚨 May cause crashes, hangs, restart loops, stalls, or process outages. label Jun 29, 2026
@RomneyDa
RomneyDa force-pushed the dallin/qa-real-e2e-step1-foundation branch from b1a083b to 863bcad Compare June 29, 2026 23:10
@RomneyDa RomneyDa changed the title test(qa): add script producer e2e fixtures test(qa): expand docker lane adapter Jun 29, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. merge-risk: 🚨 availability 🚨 May cause crashes, hangs, restart loops, stalls, or process outages. labels Jun 29, 2026
@RomneyDa

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@RomneyDa
RomneyDa force-pushed the dallin/qa-real-e2e-step1-foundation branch from 863bcad to c5d4b32 Compare June 29, 2026 23:28
@openclaw-barnacle openclaw-barnacle Bot removed scripts Repository scripts docker Docker and sandbox tooling labels Jun 29, 2026
@RomneyDa

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts docker Docker and sandbox tooling size: L and removed size: M labels Jun 29, 2026
@RomneyDa
RomneyDa merged commit fd3f354 into main Jun 30, 2026
112 of 116 checks passed
@RomneyDa
RomneyDa deleted the dallin/qa-real-e2e-step1-foundation branch June 30, 2026 00:08
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 30, 2026
* test(qa): expand docker lane adapter

* Extract QA Docker lane fixture
chenyangjun-xy pushed a commit to chenyangjun-xy/openclaw that referenced this pull request Jul 1, 2026
* test(qa): expand docker lane adapter

* Extract QA Docker lane fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Docker and sandbox tooling extensions: qa-lab maintainer Maintainer-authored PR merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. scripts Repository scripts size: L status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant