test(qa): expand docker lane adapter - #97937
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 29, 2026, 8:02 PM ET / 00:02 UTC. Summary PR surface: Source -170, Tests +142, Other -90. Total -118 across 19 files. Reproducibility: not applicable. as a bug report. The reviewable behavior is source-checkable: current main lacks the new discovery modes and aliases, while the PR head adds them and repoints Docker-backed YAML scenarios to the moved adapter. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land after maintainer review confirms the lane registry and discovery contract and exact-head CI/QA evidence for the moved adapter. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug report. The reviewable behavior is source-checkable: current main lacks the new discovery modes and aliases, while the PR head adds them and repoints Docker-backed YAML scenarios to the moved adapter. Is this the best way to solve the issue? Yes. Moving the adapter under QA Lab runtime while keeping heavy Docker shell scripts as thin entrypoints is the narrow owner-boundary cleanup, and deleting the unused qa-transport helper avoids preserving a dead private surface. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 18b2ff683fd3. Label changesLabel justifications:
Evidence reviewedPR surface: Source -170, Tests +142, Other -90. Total -118 across 19 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
5f0daf2 to
88d7628
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
88d7628 to
b1a083b
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
b1a083b to
863bcad
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
863bcad to
c5d4b32
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
* test(qa): expand docker lane adapter * Extract QA Docker lane fixture
* test(qa): expand docker lane adapter * Extract QA Docker lane fixture
What Problem This Solves
Keeps step 1 of the real-E2E QA cleanup focused on QA-owned Docker lane dispatch without leaving unused QA helper modules behind.
The Docker-backed scenarios were still routing through
scripts/qa/docker-e2e-lane.ts. This PR moves that adapter into QA Lab runtime code so the scenario executable lives with the QA fixtures, while the existing heavy Docker shell scripts remain the thin lane entrypoints they already are.Why This Change Was Made
scripts/qa/docker-e2e-lane.tstotest/e2e/qa-lab/runtime/docker-e2e-lane.ts.--listand--helpto the adapter so scenario wrappers can discover/validate lane names without duplicating the map.qa-transport-scenarioshelper and its unit test instead of preserving an unused re-export/helper surface.live-transport-scenarios.ts; live transport code continues to use the existing SDK seam directly.User Impact
No taxonomy IDs, product runtime behavior, or QA scenario coverage claims change. This is QA infrastructure cleanup that keeps script-to-QA migrations grounded in QA-owned executables without adding unused helper APIs.
Evidence
node --import tsx test/e2e/qa-lab/runtime/docker-e2e-lane.ts --listnode --import tsx test/e2e/qa-lab/runtime/docker-e2e-lane.ts --helpnode scripts/run-vitest.mjs extensions/qa-lab/src/scenario-catalog.test.ts --reporter=verbosepnpm deadcode:unused-filespnpm deadcode:dependenciespnpm check:test-typespnpm exec oxfmt --check test/e2e/qa-lab/runtime/docker-e2e-lane.ts qa/scenarios/runtime/docker-gateway-network.yaml qa/scenarios/plugins/clawhub-marketplace-list.yamlgit diff --check.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/mainclean