fix(nvidia): use Nemotron Super 1M context - #98726
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 2:39 PM ET / 18:39 UTC. Summary PR surface: Source 0, Tests +4, Docs 0. Total +4 across 3 files. Reproducibility: yes. for the source-level merge risk: current main and the live NVIDIA feed use 262,144 for Super, while PR head changes only the bundled fallback to 1,048,576. There is no high-confidence user-flow proof that the hosted OpenClaw NVIDIA path should use the larger fallback limit today. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the bundled fallback aligned with NVIDIA's hosted featured feed unless NVIDIA raises the hosted row or maintainers explicitly sponsor and prove a separate long-context fallback policy. Do we have a high-confidence way to reproduce the issue? Yes for the source-level merge risk: current main and the live NVIDIA feed use 262,144 for Super, while PR head changes only the bundled fallback to 1,048,576. There is no high-confidence user-flow proof that the hosted OpenClaw NVIDIA path should use the larger fallback limit today. Is this the best way to solve the issue? No. The edit is narrow, but changing only fallback metadata is not the best fix without maintainer sponsorship because it diverges from the hosted feed contract; alignment or an explicit long-context policy is safer. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 477b27b6f87e. Label changesLabel justifications:
Evidence reviewedPR surface: Source 0, Tests +4, Docs 0. Total +4 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
* fix(nvidia): correct Nemotron Super context
* fix(nvidia): correct Nemotron Super context
Summary
Correct the bundled NVIDIA Nemotron 3 Super metadata so OpenClaw's fallback catalog uses a 1,048,576-token context window.
Changes
Validation
node scripts/run-vitest.mjs extensions/nvidiapassed.git diff --checkpassed.Notes
agents.defaults.contextTokenscaps remain authoritative.What Problem This Solves
The bundled fallback catalog advertised 262,144 tokens for Nemotron 3 Super even though the model supports a 1M-token context. Users relying on the bundled fallback could therefore compact earlier than necessary.
Why This Change Was Made
The bundled metadata now represents the model's 1M context as 1,048,576 tokens. The separate public featured-model feed remains provider-owned and passes through unchanged.
User Impact
Users of the bundled NVIDIA fallback catalog receive a 1,048,576-token context budget. Users receiving the live featured catalog continue to use NVIDIA's published feed value.
Evidence