Repository navigation
feat: attach a DOI to a dataset - #3735
Merged
Merged
Conversation
Contributor
|
👏 pour moi pas de rétractation |
…cept, inline imports, missing negative test
…h through callers
…e, keeping existing archival dates
nicolaskempf57
approved these changes
Sep 30, 2026
| _put_doi(dataset.doi, _doi_metadata(dataset)) | ||
|
|
||
|
|
||
| @task(route="high.dataset") |
Contributor
There was a problem hiding this comment.
Do me want a retry policy here to handle a downtime from DataCite ? Otherwise I guess the doi update is postponed to the next dataset title / org update or org name update.
Something like autoretry_for=(requests.RequestException,),retry_backoff=60, max_retries=3
Contributor
There was a problem hiding this comment.
We do not have any autoretry in udata so I was reticent to add it but maybe it's worth it for this task in particular…
Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
ThibaudDauce
added a commit
to datagouv/cdata
that referenced
this pull request
Oct 7, 2026
…st one (#1238) - Require opendatateam/udata#3735 - Part of datagouv/data.gouv.fr#1983 (affichage et demande de DOI ; les formats de citation restent à faire)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See datagouv/data.gouv.fr#1983
Mints a DOI for a dataset, stores it, and pushes the metadata back to DataCite when the title or the organization changes.
The two open questions are settled:
doifield on the dataset, not an extrapurge_datasets)Minting is
POST /datasets/{id}/doi, sysadmin only. The citation block and the "request a DOI" button are not here.Checked against the sandbox instead of guessed:
PUT /dois/{doi}upserts, so creation is idempotent and the 422 special case is gone, and a PUT withouteventkeeps the DOI findable. The recorded URL is the permalink, not the slug, which follows the title.New settings to set on deploy:
DOI_PREFIXDOI_REPO_USERDOI_REPO_PASSWORDDOI_PLATFORM_URI,https://api.test.datacite.orgoutside production