Skip to content

Failed Save - partially completed #3582

Description

@MichaelAtOz

This is probably a matter of taste, but current behaviour is unpalatable to me.

With a new file, File/Save to a location you do not have write permission, give it a proper filename in the save dialogue.
Gets a dialogue box with the following (and in console)

Failed to open file for writing /usr/share/openscad-nightly/examples/Basics/sphere-chopped.scad (Permission denied)

OK so far.

But it then progresses to give the Tab/Title the new filename.
I would expect it to be an atomic operation, if the save fails, the 'untitled.scad' instance stays as it was.

This also happens with Save-As, the editor takes on the new filename, even though it does not exist.
Also the * in the Tab/Title, signifying editor has changes, is no longer shown,
although if you close it, you do get the 'file changed' prompt.

This was on Debian w 2020.12.15.

Activity

  1. t-paul commented on Jan 4, 2021

    @t-paul
    Member

    Can you verify with the latest snapshot? I believe that is fixed via #3576.

  2. MichaelAtOz commented on Jan 4, 2021

    @MichaelAtOz
    MemberAuthor

    Screenshot from 2021-01-05 10-35-21
    Nope, not fixed, 2020.01.03-nightly, File/New, File/Save, select un-writable directory, give it a name 'save-bug.scad', write error, but editor takes on new name. And same with Save-as, including loss of *.

    I'll give it a go on Windows.

  3. MichaelAtOz commented on Jan 5, 2021

    @MichaelAtOz
    MemberAuthor

    I'm not a Windows security permissions specialist, I just setup a directory and selected Deny-write.

    On Windows, something checks whether it can be written at the Save dialogue box level.

    Capture-save-as-bug

    Given the dialogue is still open, I assume that something is Windows not OpenSCAD??

  4. added a commit that references this issue on Jan 5, 2021
    10b61c1
  5. t-paul commented on Jan 5, 2021

    @t-paul
    Member

    Aha, the change I had in mind did cover the recent list, not the editor path update.

  6. added 2 commits that reference this issue on Jan 5, 2021
    cac0442
    ed24530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions