writeread: add -v option to pin the (D)TLS protocol version - #96
Closed
quarckster wants to merge 1 commit into
Closed
quarckster wants to merge 1 commit into
quarckster wants to merge 1 commit into
Conversation
mattcaswell
approved these changes
Sep 10, 2026
mattcaswell
left a comment
Member
There was a problem hiding this comment.
The CI test failures don't look relevant to this PR (but it looks like we need to fix something)
Member
Author
|
esyr
approved these changes
Sep 10, 2026
Since the DTLS 1.3 merge, writeread -d negotiates DTLS 1.3 on master and 4.1 but DTLS 1.2 everywhere else, mixing two protocols in one benchmark series. -v 1.2|1.3 pins min and max version so each can be measured separately. DTLS 1.3 is guarded so the tool still builds against 3.x. Assisted-by: Claude:claude-fable-5-1
quarckster
force-pushed
the
writeread-proto-version
branch
from
September 11, 2026 13:51
86d6e18 to
b219371
Compare
t8m
approved these changes
Sep 11, 2026
t8m
pushed a commit
that referenced
this pull request
Sep 14, 2026
Since the DTLS 1.3 merge, writeread -d negotiates DTLS 1.3 on master and 4.1 but DTLS 1.2 everywhere else, mixing two protocols in one benchmark series. -v 1.2|1.3 pins min and max version so each can be measured separately. DTLS 1.3 is guarded so the tool still builds against 3.x. Assisted-by: Claude:claude-fable-5-1 Reviewed-by: Matt Caswell <matt@openssl.foundation> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Merge-date: Mon Sep 14 09:52:37 2026 Merged-from: #96
Member
|
Merged. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the DTLS 1.3 merge, writeread -d negotiates DTLS 1.3 on master and 4.1 but DTLS 1.2 everywhere else, mixing two protocols in one benchmark series. -v 1.2|1.3 pins min and max version so each can be measured separately. DTLS 1.3 is guarded so the tool still builds against 3.x.
Assisted-by: Claude:claude-fable-5-1