Conversation
Yu-0312
force-pushed
the
pr-1952-gdscript-body-range
branch
from
September 20, 2026 09:48
114be39 to
dc88cf2
Compare
Yu-0312
force-pushed
the
pr-1952-gdscript-body-range
branch
from
September 20, 2026 16:46
dc88cf2 to
61a5e7d
Compare
Contributor
Author
|
Rebased onto current Remaining CI red on some jobs (ccls / R / nextflow / clojure / perl) also fails on unrelated PRs and looks like runner/LS flake — happy to re-run if needed. Ready for review when you have bandwidth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1952.
replace_symbol_bodydeleted the blank separator immediately before the next GDScript function because Godot reports a symbol range ending at the start of the next top-level construct (or on the blank line).Change
In
GodotLanguageServer._fix_symbol_ranges, after the existing off-by-one end-column fix,_clamp_trailing_blank_lineswalks the range end back to the last non-blank line of the symbol.selectionRange(the identifier) is not clamped. Document-symbol cache version bumped to 2.Tests
test_godot_range_clamp.py: clamp unit cases + end-to-end_fix_symbol_rangeson a two-function fixture;selectionRangepreserved.Checklist
CHANGELOG.mdupdatedFurther ideas for maintainers (not in this PR)
replace_symbol_bodyon two adjacent functions) would pin this against a live LS; only pure-function tests here._fix_range_end).