Skip to content

Add support for semantic versioning - #93

Merged
dmitrym0 merged 1 commit into
masterfrom
feature/semver
Sep 15, 2024
Merged

dmitrym0 merged 1 commit into
masterfrom
feature/semver

Conversation

@dmitrym0

Copy link
Copy Markdown
Member

Problem

We've been stuck on version 1.5.0 since last year.

Solution

Use svu to manage org-noter's semantic version along with a few Makefile changes.

Steps to Test

  1. Pull this branch
  2. Install svu
  3. Run make bump-patch or make bump-minor to increment the appropriate version.
  • See that an appropriate tag is added (git tag -l)
  • See that the exact same version string is applied to the ;;Version header in org-noter.el.

@petermao

Copy link
Copy Markdown
Member

No objections to this, but we should meet some time over jitsi so you can show me how to work this feature.

the year of horror is coming to a close for me...

@dmitrym0
dmitrym0 merged commit 32ccaf1 into master Sep 15, 2024
@dmitrym0
dmitrym0 deleted the feature/semver branch September 15, 2024 02:38
@stzsch

stzsch commented Sep 16, 2024

Copy link
Copy Markdown

fwiw this change makes elpaca complain about org-noter version:

log:
[2024-09-16 17:09:46] Package queued
[2024-09-16 17:09:47] Continued by: elpaca--process
[2024-09-16 17:09:47] Continued by: elpaca--configure-remotes
[2024-09-16 17:09:47] Continued by: elpaca--checkout-ref
[2024-09-16 17:09:47] Continued by: elpaca--dispatch-build-commands
[2024-09-16 17:09:47] Queueing Dependencies
[2024-09-16 17:09:47] Continued by: elpaca--queue-dependencies
[2024-09-16 17:09:47] Checking dependency versions
[2024-09-16 17:09:47] elpaca--check-version: (error "Invalid version syntax: ‘v1.6.0’ (must start with a number)")

This is because version-to-list craps out when supplied the version string prefixed with "v".

I don't think it's an invalid format though, going from melpa's recipe format spec (https://github.com/melpa/melpa#recipe-format). Seems like their default regex deals with this.

The error occurs because elpaca checks the version using elpaca--check-version with its own regex. They could fix the regex I guess.

But from a quick grep seems like the prefix is quite uncommon in the package header, at least in the packages I have installed:

user:~/.config/emacs/elpaca/repos
$ rg "^;; Version: [0-9]" | rg ".el" | wc -l
446
user:~/.config/emacs/elpaca/repos
$ rg "^;; Version: v" | wc -l
1

@dmitrym0 dmitrym0 mentioned this pull request Sep 17, 2024
@dmitrym0

Copy link
Copy Markdown
Member Author

fwiw this change makes elpaca complain about org-noter version:

Thank you, I updated the version in the latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants