Skip to content

fix(args): set the include-path if workdir is set - #1293

Merged
orhun merged 6 commits into
mainfrom
fix/workdir-include-path
Dec 14, 2025
Merged

fix(args): set the include-path if workdir is set#1293
orhun merged 6 commits into
mainfrom
fix/workdir-include-path

Conversation

@orhun

@orhun orhun commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

Description

If --workdir is set to a path, it should take affect as --include-path as well.

Motivation and Context

Before:

git cliff -w my_crate --include-path x

After:

git cliff -w my_crate

fixes #1292

How Has This Been Tested?

Test fixtures

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter

codecov-commenter commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.50%. Comparing base (c8aad00) to head (33d263c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   43.56%   43.50%   -0.05%     
==========================================
  Files          23       23              
  Lines        2241     2244       +3     
==========================================
  Hits          976      976              
- Misses       1265     1268       +3
Flag Coverage Δ
unit-tests 43.50% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun orhun mentioned this pull request Oct 22, 2025
Closed
1 task done
@ognis1205 ognis1205 mentioned this pull request Oct 24, 2025
Merged
11 of 16 tasks
@orhun
orhun merged commit 50b8312 into main Dec 14, 2025
94 of 95 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 14, 2025
Merged
@ognis1205 ognis1205 mentioned this pull request Dec 15, 2025
Closed
1 task done
@ids-mau ids-mau mentioned this pull request Feb 9, 2026
Closed
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting workdir doesn't change included paths

2 participants

@orhun @codecov-commenter