Skip to content

feat(git): improve the set commit range error - #990

Merged
orhun merged 1 commit into
mainfrom
refactor/improve_range_error
Jan 10, 2025
Merged

feat(git): improve the set commit range error#990
orhun merged 1 commit into
mainfrom
refactor/improve_range_error

Conversation

@orhun

@orhun orhun commented Dec 19, 2024

Copy link
Copy Markdown
Owner

Description

Before:

>_ orhun ζ git cliff test
 ERROR git_cliff > Git error: `unable to parse OID - contains invalid characters; class=Invalid (3)`

After:

>_ orhun ζ git cliff test
 ERROR git_cliff > Failed to set the commit range: unable to parse OID - contains invalid characters; class=Invalid (3)
"test" is not a valid commit range. Did you provide the correct arguments?

Motivation and Context

see #986

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@orhun orhun mentioned this pull request Dec 19, 2024
Closed
1 task done
@codecov-commenter

codecov-commenter commented Dec 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.82%. Comparing base (e85888f) to head (e9066ce).
⚠️ Report is 229 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff-core/src/repo.rs 66.67% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   42.85%   42.82%   -0.03%     
==========================================
  Files          21       21              
  Lines        1734     1740       +6     
==========================================
+ Hits          743      745       +2     
- Misses        991      995       +4
Flag Coverage Δ
unit-tests 42.82% <66.67%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

orhun
orhun commented Jan 10, 2025
View reviewed changes

@orhun orhun left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orhun
orhun merged commit f29e815 into main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@orhun @codecov-commenter