Repository navigation
refactor(sysctl): Refactor some controller code - #146
Merged
Merged
Conversation
This makes the code a bit less "mutable", so to say. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This patch refactors the two nested if expressions into one if. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Contributor
Author
|
A quick bisect told me that the first patch of this series broke this... which I do not understand... do you have some insight? |
Owner
|
Yup, I just checked |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
refactor-controller-code
branch
from
October 28, 2023 11:54
0d2ae87 to
f92f12d
Compare
Contributor
Author
|
Should be fixed now, please have another look! 🎉 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 76.22% 76.09% -0.13%
==========================================
Files 23 23
Lines 1501 1497 -4
==========================================
- Hits 1144 1139 -5
- Misses 357 358 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orhun
approved these changes
Oct 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some more code refactoring
Motivation and Context
Not required at all, just found that nice.
How Has This Been Tested?
It hasn't 😆
Screenshots / Logs (if applicable)
Types of Changes
Checklist: