Conversation
Bind github.event.inputs.version under env: before mike deploy so the free-string input is not interpolated into shell script text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2110
Description
CI hygiene for
.github/workflows/docs.ymlmanual docs deploy path.Bind
github.event.inputs.versionunderenv:beforemike deployinrun:(quoted$MIKE_VERSION).Mirrors the release path in the same file that already uses
env:/$MIKE_VERSION.Defense-in-depth for privileged docs deploy — not framed as a vulnerability ticket.
Follow the
CONTRIBUTINGGuide.Make your Pull Request title follow the Conventional Commits specification and repository rules (e.g.,
docs(spec):fordocs/specification.md,docs:for other docs, andfeat:/fix:reserved fora2a.proto). See CONTRIBUTING.md for details.Ensure the tests and linter pass (Run
bash scripts/format.shfrom the repository root to format)Appropriate docs were updated (if necessary)
Test plan
workflow_dispatchwith a stable version string when maintainers want