Argument parsing, usage statement, and small improvements for countKmers#11
Open
standage wants to merge 4 commits into
Open
Argument parsing, usage statement, and small improvements for countKmers#11standage wants to merge 4 commits into
standage wants to merge 4 commits into
Conversation
standage
commented
Feb 15, 2019
| @@ -1,72 +0,0 @@ | |||
| HAWK version 0.9.8 | |||
Author
There was a problem hiding this comment.
This file is redundant with README.md, and some parts are out of date. Better to just drop it.
| CATCMD="bunzip2 -c" | ||
| else | ||
| CATCMD=cat | ||
| fi |
Author
There was a problem hiding this comment.
Here is where the compression is autodetected.
standage
commented
Feb 15, 2019
| jellyfishDir=/home/atif/jellyfish-Hawk/bin #directory where jellyfish is installed | ||
| sortDir=/home/atif/coreutils/deps/bin #directory where parallel sort is installed | ||
| #!/usr/bin/env bash | ||
| set -eo pipefail |
Author
There was a problem hiding this comment.
It's helpful to halt execution if something goes wrong. Makes it easier to isolate the point of failure if it doesn't just try to keep going to the next sample.
added 2 commits
February 21, 2019 14:53
Author
|
Rolled back the text about Jellyfish 2. |
Owner
|
Thank you so much for your modifications! Incorporated a few. We are working on a few things. We will take care of the rest once that's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes to the
countKmersscript for my own use, and thought they might be useful for others as well../countKmers -h.gzor not and dynamically determines whether to usezcatorcat, again so users don't have to modify the scriptI also updated
README.mdto reflect these changes,and the fact that Jellyfish 2 is a suitable alternative to the modified version of Jellyfish bundled with HAWK which seems to be giving some users issues.