Option to disable create/update the user/group running minio & add by default create_home: no#44
Open
fititnt wants to merge 1 commit into
Open
Option to disable create/update the user/group running minio & add by default create_home: no#44fititnt wants to merge 1 commit into
fititnt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #43
This pull request allow disable management from this role for the specified
minio_userandminio_group(but by default keep old behavior). The variable used isminio_usergroup_manage: true(We could use other name).This pull request also implement @SuperQ suggestion from #15 (comment). So by default if this role have to manage user, it will not try create the home directory.
About tests:
Issues to consider when changing in production
When updating the user/group from this role, consider that not only the data directories, but also a folder named
.minio.sysat your root data directory may still have the older permissions values and this will make your minio instances restart too quickly.