Skip to content

add missing prefix to variables - #3

Closed
brennerm wants to merge 1 commit into
atosatto:masterfrom
brennerm:add-variable-prefix
Closed

add missing prefix to variables#3
brennerm wants to merge 1 commit into
atosatto:masterfrom
brennerm:add-variable-prefix

Conversation

@brennerm

Copy link
Copy Markdown

This prevents collision with variables from other roles.

@atosatto

Copy link
Copy Markdown
Owner

The failing CI has been fixed in #4.
All the rest, LGTM! :)

Thanks!!!

@atosatto
atosatto requested review from SuperQ and paulfantom June 24, 2018 22:13

@paulfantom paulfantom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread README.md

skip_server: False
skip_client: False
minio_skip_server: False

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to positive wording to avoid the confusing double negative?

minio_install_server: true
minio_install_client: true

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this would be better

@SuperQ

SuperQ commented Jun 25, 2018

Copy link
Copy Markdown
Collaborator

Superseded by #5.

@SuperQ SuperQ closed this Jun 25, 2018
lucendio referenced this pull request in wireapp/ansible-minio Nov 20, 2020
allow specifying minio_{client,server}_{download_url,checksum}
akire0ne pushed a commit to akire0ne/ansible-minio that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants