fix(sae): don't report a gas-time gap after restart - #6008
Open
JonathanOppenheimer wants to merge 1 commit into
Open
JonathanOppenheimer wants to merge 1 commit into
JonathanOppenheimer wants to merge 1 commit into
Conversation
JonathanOppenheimer
requested review from
ARR4N and
StephenButtolph
as code owners
September 22, 2026 16:42
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Fixes SAE gas-time gap metrics after restart by treating missing wall-clock timestamps as unknown.
Changes:
- Detects zero wall-clock execution timestamps.
- Reports
NaNwhen timing data is unavailable. - Preserves normal gap calculations.
| File | Summary |
|---|---|
vms/saevm/saexec/metrics.go |
Handles missing wall-clock timestamps during metric initialization and execution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The wall-clock execution time isn't persisted, so a node that restarts seeds its metrics from a block with the zero
[time.Time]. Subtracting that maxes out the duration, andgas_time_wall_time_gap_secondsreports ~9.2e9 seconds until the first block executes. On Helicon launch every mainnet node did this on the last restart, which msesses up the the scaling of the dashboard that uses it.Note that we should still set
NaN, otherwise ti would appear perfectly healthy w/ 0.How this works
How this was tested
We don't test metrics
Need to be documented in RELEASES.md?
No