fix: use resource_default_view in frame field default_view#4658
Merged
Conversation
skip_show_view was removed from Avo.configuration and replaced by resource_default_view; the frame field still called the removed method.
Contributor
|
This PR has been merged into Please check the release guide for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avo::Fields::FrameBaseField#default_viewcalledAvo.configuration.skip_show_view, which was removed and replaced byresource_default_view(aViewInquirer). The old call would raiseNoMethodError.This maps the old behavior faithfully:
Matches how
spec/system/avo/group_3/skip_show_view_spec.rbalready setsresource_default_view = :edit.Note
Low Risk
Single-line config API swap with equivalent behavior; no auth or data-path changes.
Overview
Avo::Fields::FrameBaseField#default_viewno longer calls the removedskip_show_viewconfig (which would raiseNoMethodError). It now usesAvo.configuration.resource_default_view.edit?to pick:editvs:show, matching the oldskip_show_view ? :edit : :showbehavior and the same pattern used elsewhere (e.g. show authorization).Reviewed by Cursor Bugbot for commit bf81966. Bugbot is set up for automated code reviews on this repo. Configure here.