Skip to content

[AVR-1897] Fix: Default DieTerm operand to 1 if missing or empty in DDB dice payloads#2263

Merged
tiberius0954 merged 1 commit into
nightlyfrom
AVR-1897
Apr 28, 2026
Merged

[AVR-1897] Fix: Default DieTerm operand to 1 if missing or empty in DDB dice payloads#2263
tiberius0954 merged 1 commit into
nightlyfrom
AVR-1897

Conversation

@tiberius0954

Copy link
Copy Markdown
Contributor

Summary

This PR addresses an issue where D&D Beyond (DDB) dice roll payloads may omit the operand field or provide it as an empty string, causing downstream errors in Avrae when constructing dice expressions. The fix ensures that when deserializing a DieTerm from a DDB payload, the operand is defaulted to 1 if it is missing or empty

Changelog Entry

Fix: Default DieTerm operand to 1 if missing or empty in DDB dice payloads

Checklist

PR Type

  • This PR is a code change that implements a feature request.
  • This PR fixes an issue.
  • This PR adds a new feature that is not an open feature request.
  • This PR is not a code change (e.g. documentation, README, ...)

Other

  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [] If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.

@tiberius0954 tiberius0954 marked this pull request as ready for review April 27, 2026 21:24
@tiberius0954 tiberius0954 merged commit 6f6aab8 into nightly Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants