[AVR-1897] Fix: Default DieTerm operand to 1 if missing or empty in DDB dice payloads#2263
Merged
Conversation
tonip-wizard
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue where D&D Beyond (DDB) dice roll payloads may omit the operand field or provide it as an empty string, causing downstream errors in Avrae when constructing dice expressions. The fix ensures that when deserializing a DieTerm from a DDB payload, the operand is defaulted to 1 if it is missing or empty
Changelog Entry
Fix: Default DieTerm operand to 1 if missing or empty in DDB dice payloads
Checklist
PR Type
Other