fix: no default values when unexpected errors occurred - #1303
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
chaoticlonghair
force-pushed
the
yangby/bugfix/remove_unwrap_or_default_fo_result
branch
from
August 4, 2023 06:57
d4bf768 to
53077bb
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
chaoticlonghair
requested review from
KaoImin and
driftluo
and removed request for
jjyr
August 4, 2023 07:41
chaoticlonghair
force-pushed
the
yangby/bugfix/remove_unwrap_or_default_fo_result
branch
from
August 7, 2023 02:26
53077bb to
5d99d3e
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
approved these changes
Aug 8, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
driftluo
approved these changes
Aug 9, 2023
chaoticlonghair
deleted the
yangby/bugfix/remove_unwrap_or_default_fo_result
branch
August 9, 2023 02:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR:
Remove
unwrap_or_defaultfor unexpected errors.Set default value directly instead of
unwrap_or_default.const fn for traitsis not released (today, latest toolchain is1.71.0), set a const value withunwrap_or(const_value)is better thanunwrap_or_default, sinceunwrap_or_defaultwill call theDefault::default(..)function.p.s.
-O3, even-O2, may ignore the call, set const value directly.More readability, a literal value is more clearly than
Default::default(..).Which issue(s) this PR fixes:
Fixes #1287
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwcCI Usage
CI Switch