Repository navigation
license: signed nonce on renew and deactivate - #578
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renew and deactivate now include a fresh 16-byte crypto/rand nonce (base64url, no padding, field
nonce) in the JSON body. The signature covers the raw body, so the nonce is signed. Matches activate's encoding; the activate nonce code now shares the helper.The API (abahmed/kwatch-api#18) dedupes the nonce per license; older API versions ignore the unknown field (the body is parsed as plain JSON with no unknown-key rejection).
Test: client_nonce_test.go checks each call sends a distinct 16-byte nonce and that the signature verifies over the body containing it.