Skip to content

Conversation

@bilelmoussaoui
Copy link

Far from ready, could use some proper review/testing but it is slightly better than current status quo

image

image

the whole sidebar needs proper design so i will wait for Allan or someone else to chime in before fixing it

As it automatically loads stylesheet and would allow nicer things later on
that is their default values
Adwaita does that automatically for us
Instead of the messy over-complicated GtkPaned and use AdwStatusPage as
well while at it
As that is the proper way to do it, instead of hacking a lot of things around.
In the next commit i will add more features wrapping the models to make it worth it
Avoids a warning when using the set_sort_func
@bilelmoussaoui
Copy link
Author

please don't review or merge yet, i got plenty more cleanup commits locally.

@allanday
Copy link
Contributor

The previous designs were a few years old and the design conventions are now outdated. I've therefore updated the mockups to follow current practice: main window, crash report assistant. You can see the previous version here for comparison. Some of the changes in the new design:

  • I called the app "Crash Reports"
  • The list of matching reports is now a list
  • Buttons have been moved out of the header bar into the main panel
  • The layout of the sidebar has changed, to avoid the repetitious "quit unexpectedly"

I'm happy to help square this with the implementation being discussed here, if there are specific questions. I can also provide guidance on which libadwaita widgets to use where.

In terms of the screenshots above, the panel generally looks good. The main thing I'd want to improve is this text:

image

It's a bit unclear to me what the motivation is for the text. Is it supposed to be an encouragement to create a Bugzilla ticket? Or is it more intended to show the current status of the report?

@AdamWill
Copy link

AdamWill commented Mar 31, 2025

The technical background there is that when a crash is detected, some minimal info about it gets sent automatically and the retrace server or whatever stores that and can recognize the crash again, but that report doesn't contain enough info to actually debug/fix the problem (usually). Generating a more detailed report is not done automatically because it's resource intensive and potentially has privacy implications, so it has to be a manual action. The message is trying to manage the gap between these two things, IIRC.

@AsciiWolf
Copy link
Contributor

We should also consider updating the screenshot in AppStream metadata when this gets merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete this file from po/POTFILES.in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to re-generate the POT file using:

meson setup . build && - meson compile -C build gnome-abrt-pot

@allanday
Copy link
Contributor

The technical background there is that when a crash is detected, some minimal info about it gets sent automatically and the retrace server or whatever stores that and can recognize the crash again, but that report doesn't contain enough info to actually debug/fix the problem (usually). Generating a more detailed report is not done automatically because it's resource intensive and potentially has privacy implications, so it has to be a manual action. The message is trying to manage the gap between these two things, IIRC.

Thanks, that makes sense (I think).

I think we could simplify this text, to make it something like "Please create a report to share detailed crash data". I've added something similar to the mockups.

@AsciiWolf
Copy link
Contributor

Any progress?

(#370 is still blocking a new Fedora build though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants