-
Notifications
You must be signed in to change notification settings - Fork 23
Various design fixes and libadwaita usage improvements #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
As it automatically loads stylesheet and would allow nicer things later on
that is their default values
Adwaita does that automatically for us
Instead of the messy over-complicated GtkPaned and use AdwStatusPage as well while at it
As that is the proper way to do it, instead of hacking a lot of things around. In the next commit i will add more features wrapping the models to make it worth it
Useless...
Avoids a warning when using the set_sort_func
|
please don't review or merge yet, i got plenty more cleanup commits locally. |
|
The previous designs were a few years old and the design conventions are now outdated. I've therefore updated the mockups to follow current practice: main window, crash report assistant. You can see the previous version here for comparison. Some of the changes in the new design:
I'm happy to help square this with the implementation being discussed here, if there are specific questions. I can also provide guidance on which libadwaita widgets to use where. In terms of the screenshots above, the panel generally looks good. The main thing I'd want to improve is this text: It's a bit unclear to me what the motivation is for the text. Is it supposed to be an encouragement to create a Bugzilla ticket? Or is it more intended to show the current status of the report? |
|
The technical background there is that when a crash is detected, some minimal info about it gets sent automatically and the retrace server or whatever stores that and can recognize the crash again, but that report doesn't contain enough info to actually debug/fix the problem (usually). Generating a more detailed report is not done automatically because it's resource intensive and potentially has privacy implications, so it has to be a manual action. The message is trying to manage the gap between these two things, IIRC. |
|
We should also consider updating the screenshot in AppStream metadata when this gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also delete this file from po/POTFILES.in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not forget to re-generate the POT file using:
meson setup . build && - meson compile -C build gnome-abrt-pot
Thanks, that makes sense (I think). I think we could simplify this text, to make it something like "Please create a report to share detailed crash data". I've added something similar to the mockups. |
|
Any progress? (#370 is still blocking a new Fedora build though.) |
Far from ready, could use some proper review/testing but it is slightly better than current status quo
the whole sidebar needs proper design so i will wait for Allan or someone else to chime in before fixing it