Skip to content

Various design fixes and libadwaita usage improvements #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bilelmoussaoui wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Various design fixes and libadwaita usage improvements #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f70dcb5
Switch to using AdwApplicationWindow
bilelmoussaoui Feb 18, 2025
24c0eb4
Get rid of no longer needed properties
bilelmoussaoui Feb 18, 2025
3f23a38
Set menus from UI files
bilelmoussaoui Feb 18, 2025
dbad996
Remove useless theme switching bits
bilelmoussaoui Feb 18, 2025
d0b6071
Avoid deprecated show/hide
bilelmoussaoui Feb 18, 2025
57518fe
Avoid deprecated get_style_context
bilelmoussaoui Feb 18, 2025
2231be1
Switch to AdwAboutDialog
bilelmoussaoui Feb 18, 2025
7bad62d
Use AdwNavigationSplitView
bilelmoussaoui Feb 18, 2025
461754f
Use AdwActionRow instead of hacked AdwPreferencesRow
bilelmoussaoui Feb 18, 2025
9f3ceb7
Various header bar button fixes
bilelmoussaoui Feb 18, 2025
595ab23
Remove unused functions
bilelmoussaoui Feb 18, 2025
018ee68
Use ListModels for filling the ListBox
bilelmoussaoui Feb 18, 2025
4e6a033
Use a FilterListModel instead of the custom Pattern matching impl
bilelmoussaoui Feb 18, 2025
a95d31a
Drop MultipleSource abstractions
bilelmoussaoui Feb 18, 2025
3893020
use a SortListModel
bilelmoussaoui Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions data/css/oops.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,3 @@
GtkListBoxRow, row {
padding: 8px;
margin: 5px;
border-radius: 12px;
}

GtkListBoxRow:selected, row:selected {
background-color: #007bff; /* Custom blue color */
color: #ffffff; /* White text color for better contrast */
}

.app-menu-button {
background-color: transparent;
border: none;
box-shadow: none;
outline: none;
padding: 0;
margin: 0;
border-radius: 5px;
}

.app-menu-button:hover {
background-color: #d3d3d3;
}

.app-menu-button:active {
background-color: #b3b3b3;
}

.app-menu-button > * {
background-color: transparent;
}

.app-name-label {
font-weight: bold;
}
Expand Down Expand Up @@ -67,20 +34,3 @@ GtkListBoxRow:selected, row:selected {
border-radius: 50%;
font-size: 10px;
}

.search-crash {
margin: 5px;
border-radius: 12px;
}

.btn-report {
background-color: transparent;
}

.btn-report:hover {
background-color: #d3d3d3;
}

.btn-report:active {
background-color: #b3b3b3;
}
7 changes: 5 additions & 2 deletions data/org.freedesktop.GnomeAbrt.gresource.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<gresources>
<gresource prefix="/org/freedesktop/GnomeAbrt">
<file>css/oops.css</file>
<file preprocess="xml-stripblanks">ui/oops-menus.ui</file>
<file alias="style.css">css/oops.css</file>
<file preprocess="xml-stripblanks">ui/oops-window.ui</file>
</gresource>

<gresource prefix="/org/freedesktop/GnomeAbrt/">
<file preprocess="xml-stripblanks">sentiment-very-satisfied-symbolic.svg</file>
</gresource>
</gresources>
2 changes: 2 additions & 0 deletions data/sentiment-very-satisfied-symbolic.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
48 changes: 0 additions & 48 deletions data/ui/oops-menus.ui
View file
Open in desktop
Copy link
Contributor

@AsciiWolf AsciiWolf Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete this file from po/POTFILES.in.

Copy link
Contributor

@AsciiWolf AsciiWolf Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to re-generate the POT file using:

meson setup . build && - meson compile -C build gnome-abrt-pot

This file was deleted.

Loading