Skip to content

[Feedback] Fix typo in getSummaryOfThreads #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 2 commits into from
Nov 11, 2024
Merged

[Feedback] Fix typo in getSummaryOfThreads #8889

driusan merged 2 commits into from
Nov 11, 2024

Conversation

@CamilleBeau
Copy link
Collaborator

@CamilleBeau CamilleBeau commented Sep 19, 2023 •
edited
Loading

Brief summary of changes

I had looked into the suspected bug and confirmed that it is indeed a bug.

This PR fixes the BVL Feedback summary in instruments by taking the commentID for query params from the array _feedbackObjectInfo instead of _feedbackCandidateProfileInfo, which only included candidate specific data instead of instrument specific data.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Outside of this PR, navigate to an instrument that has at least one feedback comment.
  2. Look at the feedback for that instrument, and check the feedback summary at the top of the window. Notice that it is indicated that there is no feedback
image 3. Load this PR and refresh the page. 4. Notice that the summary exists and holds accurate information

image

@miladheshmati miladheshmati added the State: Needs work PR awaiting additional work by the author to proceed label Jan 15, 2024
@miladheshmati
Copy link
Contributor

miladheshmati commented Jan 15, 2024

As I check out the PR and do a make dev, I'm getting a 500 error:

[Mon Jan 15 09:26:00.037402 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/LorisInstance.php(111): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Router/BaseRouter.php(108): LORIS\\LorisInstance->hasModule()\n#3 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#4 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#5 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#6 {main}
[Mon Jan 15 09:26:00.201475 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/dashboard.class.inc(86): Module::getActiveModules()\n#2 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#3 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#4 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#5 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#6 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#7 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#8 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#9 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#10 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#11 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#12 {main}
[Mon Jan 15 09:26:00.396859 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/module.class.inc(140): Module::getActiveModules()\n#2 /var/www/loris/modules/dashboard/php/module.class.inc(58): LORIS\\dashboard\\Module->_getTasksWidget()\n#3 /var/www/loris/modules/dashboard/php/dashboard.class.inc(92): LORIS\\dashboard\\Module->getWidgets()\n#4 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#5 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#6 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#7 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#8 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#9 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#10 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#11 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#12 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#13 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#14 {main}
[Mon Jan 15 09:26:00.536259 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(59): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}
[Mon Jan 15 09:26:00.546578 2024] [php:error] [pid 104055] [client 192.168.122.1:54428] PHP Fatal error:  Uncaught ConfigurationException: Config setting css does not exist in database in /var/www/loris/php/libraries/NDB_Config.class.inc:303\nStack trace:\n#0 /var/www/loris/php/libraries/NDB_Config.class.inc(415): NDB_Config->getSettingFromDB()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(136): NDB_Config->getSetting()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}\n  thrown in /var/www/loris/php/libraries/NDB_Config.class.inc on line 303

@miladheshmati
Copy link
Contributor

miladheshmati commented Jan 25, 2024 

[Thu Jan 25 11:56:31.424593 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/LorisInstance.php(111): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Router/BaseRouter.php(108): LORIS\\LorisInstance->hasModule()\n#3 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#4 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#5 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#6 {main}
[Thu Jan 25 11:56:31.554730 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/dashboard.class.inc(86): Module::getActiveModules()\n#2 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#3 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#4 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#5 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#6 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#7 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#8 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#9 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#10 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#11 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#12 {main}
[Thu Jan 25 11:56:31.740144 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/module.class.inc(140): Module::getActiveModules()\n#2 /var/www/loris/modules/dashboard/php/module.class.inc(58): LORIS\\dashboard\\Module->_getTasksWidget()\n#3 /var/www/loris/modules/dashboard/php/dashboard.class.inc(92): LORIS\\dashboard\\Module->getWidgets()\n#4 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#5 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#6 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#7 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#8 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#9 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#10 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#11 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#12 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#13 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#14 {main}
[Thu Jan 25 11:56:31.871868 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(59): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}
[Thu Jan 25 11:56:31.880673 2024] [php:error] [pid 37075] [client 192.168.122.1:36620] PHP Fatal error:  Uncaught ConfigurationException: Config setting css does not exist in database in /var/www/loris/php/libraries/NDB_Config.class.inc:303\nStack trace:\n#0 /var/www/loris/php/libraries/NDB_Config.class.inc(415): NDB_Config->getSettingFromDB()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(136): NDB_Config->getSetting()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}\n  thrown in /var/www/loris/php/libraries/NDB_Config.class.inc on line 303

@CamilleBeau CamilleBeau force-pushed the 2023_09_19_Feedback_Typo branch from f4ec431 to a67466c Compare February 6, 2024 15:40
@miladheshmati miladheshmati added Passed manual tests PR has been successfully tested by at least one peer and removed State: Needs work PR awaiting additional work by the author to proceed labels Feb 7, 2024
@ridz1208 ridz1208 added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jun 14, 2024
@ridz1208 ridz1208 assigned CamilleBeau and unassigned miladheshmati Jul 2, 2024
@CamilleBeau CamilleBeau changed the base branch from 24.1-release to main July 8, 2024 18:01
@CamilleBeau CamilleBeau removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jul 8, 2024
@maximemulder maximemulder self-assigned this Jul 25, 2024
maximemulder
maximemulder previously approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@maximemulder maximemulder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good + Works on my machine

@driusan
Copy link
Collaborator

driusan commented Aug 12, 2024

@CamilleBeau is this supposed to go to main or to the next bugfix release?

@CamilleBeau
Copy link
Collaborator Author

CamilleBeau commented Aug 12, 2024

@CamilleBeau is this supposed to go to main or to the next bugfix release?

@driusan It could go to the bugfix release. What branch is that?

@CamilleBeau CamilleBeau force-pushed the 2023_09_19_Feedback_Typo branch from a67466c to f35cb50 Compare August 13, 2024 15:28
@CamilleBeau CamilleBeau changed the base branch from main to 26.0-release August 13, 2024 15:29
@CamilleBeau CamilleBeau dismissed maximemulder’s stale review August 13, 2024 15:29

The base branch was changed.

@driusan driusan merged commit 0254ec0 into aces:26.0-release Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximemulder maximemulder maximemulder left review comments

Assignees

@maximemulder maximemulder

@CamilleBeau CamilleBeau

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CamilleBeau @miladheshmati @driusan @maximemulder @ridz1208