Skip to content

[Feedback] Fix typo in getSummaryOfThreads #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driusan merged 2 commits into from
Nov 11, 2024
Merged

[Feedback] Fix typo in getSummaryOfThreads #8889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b04fc7
[Feedback] Fix typo in getSummaryOfThreadsg
CamilleBeau Sep 19, 2023
f35cb50
Fix changelog
CamilleBeau Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ the `Data` key instead of `$InstrumentName` (PR #7857)
- Fixed broken DB calls in `assign_missing_instruments` and `instruments` (PR #8162)
- Add support for PHP 8.1 (PR #7989)
- Fix Project tab of Configuration module to give correct errors, and prevent saving without Alias (PR #8349)
- Fix BVL feedback summary in instruments (PR #8889)
### Modules
#### API
- Ability to use PSCID instead of the CandID in the candidates API (PR #8138)
Expand Down
2 changes: 1 addition & 1 deletion php/libraries/NDB_BVL_Feedback.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ class NDB_BVL_Feedback
}
if (!empty($this->_feedbackObjectInfo['CommentID'])) {
$query .= " AND ft.CommentID = :ComID";
$qparams['ComID'] = $this->_feedbackCandidateProfileInfo['CommentID'];
$qparams['ComID'] = $this->_feedbackObjectInfo['CommentID'];
}

if (!$hasReadPermission) {
Expand Down