Fixes Response::getBody->getContents() returns empty string (#34) - #35
Merged
Conversation
itafroma
approved these changes
Jan 9, 2018
Contributor
|
Thanks for this, looks great! Merged. |
Contributor
|
Released as part of v3.2.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the ResponseSigner::signResponse($response), the stream of the response body wasn't rewound, meaning calling (the same instance of) $response->getBody()->getContents() afterwards when using the middleware would always return an empty string. However, using Response::getBody() as a string through implicit or explicit casting would already work previously, because __toString() always rewinds.
Unit test included, breaks as expected with previous version of signResponse().