ACM-484: Add a base64 key/secret encoder - #36
Closed
kasisnu wants to merge 1 commit into
Closed
Conversation
itafroma
reviewed
Jan 10, 2018
itafroma
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! I think I'm okay with this in principle as a convenience class, although the same can be accomplished using the provided KeyLoader:
$loader = new KeyLoader(array_map('base64_encode', $keys));Base64KeyLoader should have unit tests, though.
| * | ||
| * These keys can be later used for signing and verifying requests. | ||
| */ | ||
| class Base64KeyLoader implements KeyLoaderInterface |
Contributor
There was a problem hiding this comment.
Since this is just a convenience wrapper around the regular KeyLoader, I think I'd prefer this extend it and simply override KeyLoader::load().
Contributor
Contributor
|
Closing in favor of #37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.