Repository navigation
feat: add support for gateway API in the helm chart - #42
Merged
Merged
Conversation
cerfedino
force-pushed
the
feat/chart-add-gatewayapi
branch
from
September 17, 2026 14:43
9588708 to
8e59df5
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Fix the HTTPRoute parentRefs example, update install notes for HTTPRoute, and restore omitted README documentation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds optional Gateway API HTTPRoute support to the Helm chart as an alternative to Ingress.
Changes:
- Adds configurable HTTPRoute values.
- Renders an optional route to the bbook Service.
- Updates generated chart documentation.
File summaries
| File | Description |
|---|---|
charts/bbook/values.yaml |
Adds HTTPRoute configuration. |
charts/bbook/templates/httproute.yaml |
Renders the HTTPRoute resource. |
charts/bbook/README.md |
Documents chart values. |
Review details
Suppressed comments (3)
charts/bbook/README.md:55
- This generated README entry now drops the
rendered through tplbehavior even thoughvalues.yamlstill documents it andtemplates/extra-objects.yamlcallstplfor every object. That makes an important chart capability, such as templated ExternalSecrets, invisible to users; keep the description synchronized with the source comment.
| extraObjects | list | `[]` | extra Kubernetes objects deployed with the chart, rendered through tpl. |
charts/bbook/README.md:82
- The README no longer warns that each replica runs its own Zoho sync job and search index, but
values.yamlstill documents this behavior. Omitting it can lead operators to scale the deployment and unintentionally duplicate Zoho synchronization work; retain the warning in the generated documentation.
| replicaCount | int | `1` | number of replicas to launch. Note: every replica runs its own Zoho sync job and search index |
charts/bbook/values.yaml:84
parentRefsis rendered directly as an array, but this example is written as a single mapping. Copying it producesparentRefs: {name: ..., namespace: ...}and the API server rejects the HTTPRoute schema; show list syntax such as[{name: infra, namespace: infra-kgateway}]and regenerate the README description.
# -- gateways to attach to, e.g. {name: infra, namespace: infra-kgateway}
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.