Skip to content

feat: add support for gateway API in the helm chart - #42

Merged
cerfedino merged 2 commits into
mainfrom
feat/chart-add-gatewayapi
Sep 17, 2026
Merged

cerfedino merged 2 commits into
mainfrom
feat/chart-add-gatewayapi

Conversation

@cerfedino

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings September 17, 2026 14:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Fix the HTTPRoute parentRefs example, update install notes for HTTPRoute, and restore omitted README documentation.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds optional Gateway API HTTPRoute support to the Helm chart as an alternative to Ingress.

Changes:

  • Adds configurable HTTPRoute values.
  • Renders an optional route to the bbook Service.
  • Updates generated chart documentation.
File summaries
File Description
charts/bbook/values.yaml Adds HTTPRoute configuration.
charts/bbook/templates/httproute.yaml Renders the HTTPRoute resource.
charts/bbook/README.md Documents chart values.
Review details

Suppressed comments (3)

charts/bbook/README.md:55

  • This generated README entry now drops the rendered through tpl behavior even though values.yaml still documents it and templates/extra-objects.yaml calls tpl for every object. That makes an important chart capability, such as templated ExternalSecrets, invisible to users; keep the description synchronized with the source comment.
| extraObjects | list | `[]` | extra Kubernetes objects deployed with the chart, rendered through tpl. |

charts/bbook/README.md:82

  • The README no longer warns that each replica runs its own Zoho sync job and search index, but values.yaml still documents this behavior. Omitting it can lead operators to scale the deployment and unintentionally duplicate Zoho synchronization work; retain the warning in the generated documentation.
| replicaCount | int | `1` | number of replicas to launch. Note: every replica runs its own Zoho sync job and search index |

charts/bbook/values.yaml:84

  • parentRefs is rendered directly as an array, but this example is written as a single mapping. Copying it produces parentRefs: {name: ..., namespace: ...} and the API server rejects the HTTPRoute schema; show list syntax such as [{name: infra, namespace: infra-kgateway}] and regenerate the README description.
  # -- gateways to attach to, e.g. {name: infra, namespace: infra-kgateway}
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread charts/bbook/templates/httproute.yaml Resolved
@cerfedino cerfedino changed the title feat: add support for gatetway API in the helm chart feat: add support for gateway API in the helm chart Sep 17, 2026
@cerfedino
cerfedino requested review from jon4hz and removed request for jon4hz September 17, 2026 15:30
@cerfedino
cerfedino merged commit 7f50984 into main Sep 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants