Skip to content

Update weekStartData.ts - #4598

Merged
snowystinger merged 1 commit into
adobe:mainfrom
rvramesh:issue-4845
May 26, 2023
Merged

Update weekStartData.ts#4598
snowystinger merged 1 commit into
adobe:mainfrom
rvramesh:issue-4845

Conversation

@rvramesh

@rvramesh rvramesh commented May 26, 2023

Copy link
Copy Markdown
Contributor

Updated weekStateData based on https://github.com/unicode-org/cldr-json/blob/fb61c0afc2b49264b32d5d7bae6f660dd2ebee34/cldr-json/cldr-core/supplemental/weekData.json

Closes #4585

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

@rvramesh rvramesh closed this May 26, 2023
@rvramesh rvramesh reopened this May 26, 2023
@snowystinger

snowystinger commented May 26, 2023

Copy link
Copy Markdown
Member

GET_BUILD

@rspbot

rspbot commented May 26, 2023

Copy link
Copy Markdown

Build successful! 🎉

@rspbot

rspbot commented May 26, 2023

Copy link
Copy Markdown
## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

LFDanLu
LFDanLu approved these changes May 26, 2023
View reviewed changes

@LFDanLu LFDanLu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@LFDanLu LFDanLu added the small review Easy to review PR label May 26, 2023
@snowystinger
snowystinger merged commit 4cc6b43 into adobe:main May 26, 2023
@devongovett devongovett mentioned this pull request May 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes
@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

small review Easy to review PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calendar: Wrong first day of week for Australian Locale

4 participants

@rvramesh @snowystinger @rspbot @LFDanLu