Skip to content

Introduce new configuration flag memory_via_R_flag to solve #4 - #5

Closed
Marc-Ruebsam wants to merge 1 commit into
adthrasher:mainfrom
Marc-Ruebsam:enhancement-issue-4
Closed

Introduce new configuration flag memory_via_R_flag to solve #4#5
Marc-Ruebsam wants to merge 1 commit into
adthrasher:mainfrom
Marc-Ruebsam:enhancement-issue-4

Conversation

@Marc-Ruebsam

Copy link
Copy Markdown

Problem:

This addresses issue #4

Solution:

The flag allows to switch between specifying memory requirements using the -M flag and the -R "rusage[mem=]" flag when submitting the jobs via bsub. The README.md file is extended accordingly.

Testing:

Job submission was successfully triggered with memory_via_R_flag = true on our cluster which requires this setting. Setting memory_via_R_flag = false reproduces the error mentione in #4.

Potential Extentions:

  1. It is currently required to set the flag to either true or false. The code could be extended to fall back to -M when memory_via_R_flag is not set.
  2. It is currently not possible to include both -M and -R "rusage[mem=]". One could think of changing it from a boolean to a character specifying one flag or the other or both.

This addresses issue adthrasher#4
The flag allows to switch between specifying memory requirements using
the -M flag and the -R "rusage[mem=]" flag when submitting the jobs via
bsub. The README.md file is extended accordingly.
@adthrasher adthrasher added the duplicate This issue or pull request already exists label Feb 7, 2024
@adthrasher

Copy link
Copy Markdown
Owner

Resolved in #6

@adthrasher adthrasher closed this Feb 7, 2024
@Marc-Ruebsam
Marc-Ruebsam deleted the enhancement-issue-4 branch February 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants