Summary
The ExportController web routes for creating and editing export templates are gated only by the class-level create_export permission, which is granted to ROLE_TEAMLEAD by default. The corresponding API routes and UI button visibility correctly require the stricter create_export_template permission, which is granted only to ROLE_ADMIN and ROLE_SUPER_ADMIN. A TEAMLEAD user can directly access the template create/edit routes to create or modify global export templates that are visible to all users including administrators.
Details
The ExportController applies the class-level annotation #[IsGranted('create_export')].
The createExportTemplate (line 210) and editExportTemplate (line 220) methods have no method-level #[IsGranted('create_export_template')] annotation. The permission hierarchy in config/packages/kimai.yaml:103,115,122-123 grants create_export to ROLE_TEAMLEAD via the EXPORT permission set, but create_export_template only to ROLE_ADMIN and ROLE_SUPER_ADMIN.
The API controller correctly requires create_export_template. The UI template (templates/export/index.html.twig:124) correctly hides the create button behind create_export_template. Only the web controller routes are missing the check.
ExportTemplate entities are global — they have no per-user or per-team scoping (src/Entity/ExportTemplate.php:19-56). Any template created or modified by a TEAMLEAD which is marked as "Available for all users" is visible to and usable by every user in the instance.
A PoC was provided, but removed for security reasons.
Impact
Any user with ROLE_TEAMLEAD can create and modify global export templates intended to be managed only by administrators. The templates control the structure and content of exported data (columns, renderer, format). While the impact is limited to data integrity manipulation of a non-security-critical resource (no RCE, no credential exposure), it violates the intended permission boundary and allows a lower-privileged user to influence the data output format used by all users including administrators.
Solution
The permission check #[IsGranted('create_export_template')] was added to the ExportController covering the methods createExportTemplate() and editExportTemplate.
See https://www.kimai.org/en/security/ghsa-rw46-qg69-vg6h for more details.
References
Summary
The
ExportControllerweb routes for creating and editing export templates are gated only by the class-levelcreate_exportpermission, which is granted toROLE_TEAMLEADby default. The corresponding API routes and UI button visibility correctly require the strictercreate_export_templatepermission, which is granted only toROLE_ADMINandROLE_SUPER_ADMIN. A TEAMLEAD user can directly access the template create/edit routes to create or modify global export templates that are visible to all users including administrators.Details
The
ExportControllerapplies the class-level annotation#[IsGranted('create_export')].The
createExportTemplate(line 210) andeditExportTemplate(line 220) methods have no method-level#[IsGranted('create_export_template')]annotation. The permission hierarchy inconfig/packages/kimai.yaml:103,115,122-123grantscreate_exporttoROLE_TEAMLEADvia theEXPORTpermission set, butcreate_export_templateonly toROLE_ADMINandROLE_SUPER_ADMIN.The API controller correctly requires
create_export_template. The UI template (templates/export/index.html.twig:124) correctly hides the create button behindcreate_export_template. Only the web controller routes are missing the check.ExportTemplateentities are global — they have no per-user or per-team scoping (src/Entity/ExportTemplate.php:19-56). Any template created or modified by a TEAMLEAD which is marked as "Available for all users" is visible to and usable by every user in the instance.A PoC was provided, but removed for security reasons.
Impact
Any user with
ROLE_TEAMLEADcan create and modify global export templates intended to be managed only by administrators. The templates control the structure and content of exported data (columns, renderer, format). While the impact is limited to data integrity manipulation of a non-security-critical resource (no RCE, no credential exposure), it violates the intended permission boundary and allows a lower-privileged user to influence the data output format used by all users including administrators.Solution
The permission check
#[IsGranted('create_export_template')]was added to theExportControllercovering the methodscreateExportTemplate()andeditExportTemplate.See https://www.kimai.org/en/security/ghsa-rw46-qg69-vg6h for more details.
References