Repository navigation
Center the navbar logo on the line of the navbar links - #43
Merged
Merged
Conversation
As an inline image the logo kept a text descender gap below it, so it sat about 3 px above the links.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the docs site the logo sat about 3 px above the "Docs" link. As an inline image it kept a text descender gap below it, and the navbar centered that taller box. The logo container is now a flex box, so the image itself is centered.
Measured in Chrome on a local build: the logo and the link both have their vertical center at 22.2 px (before: 18.9 px and 22.2 px).