Repository navigation
Raise on every rank when the native DeepEP constructor fails on one - #46
Open
almogtavor wants to merge 1 commit into
Open
almogtavor wants to merge 1 commit into
almogtavor wants to merge 1 commit into
Conversation
The native constructor now holds only the steps that can fail on one rank alone. The collective steps (ncclDevCommCreate, ncclCommWindowRegister) move to connect(), and the ranks gather their construction status between the two.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review of #37: a failure inside the native constructor on one rank left its peers waiting in NCCL.
ncclMemAlloc, host workspace).ncclDevCommCreate,ncclCommWindowRegister) move to a newconnect().afdep/deepep.pygathers the construction status of every rank between the two, so every rank raises together.Limit: a failure inside
connect()itself is still one-sided.Checked on 4x H100, native source digest
62530ba60db1838a85338c79a2d6226b37b87a689229e90aa27e5c51506d0cc9:tests.gpu.construct_failure(every rank raises),tests.gpu.deepepwith--payload fp8andbf16, unit tests, Ruff.