fix(continuous-learning-v2): accept claude-vscode as valid entrypoint - #2134

tests/hooks/observe-entrypoint-allowlist.test.js (3)

57-61: ⚡ Quick win

Avoid silently swallowing cleanup failures.

Line 57-61 has an empty catch block. At minimum, capture and surface cleanup errors in a controlled way (e.g., debug output) so failures are diagnosable.

As per coding guidelines, "Always handle errors explicitly at every level and never silently swallow errors".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/hooks/observe-entrypoint-allowlist.test.js` around lines 57 - 61, The
empty catch around fs.rmSync(dir, { recursive: true, force: true }) swallows
cleanup errors; update the catch to explicitly handle and surface failures
(e.g., log with console.error or the test logger) including the directory name
and error object so failures are diagnosable, or rethrow if appropriate for the
test; locate the try/catch that wraps fs.rmSync for variable dir in
tests/hooks/observe-entrypoint-allowlist.test.js and replace the silent ignore
with an explicit error handling statement that records the error details.

---

103-114: ⚡ Quick win

Make Layer 2 trace detection less brittle across Bash/xtrace formats.

LAYER2_TRACE_MARKER currently depends on one exact quoted trace literal. A regex-based check for the semantic condition (minimal profile comparison) would reduce false negatives across environments.

Proposed robust matcher

-const LAYER2_TRACE_MARKER = "'[' minimal = minimal ']'";
+const LAYER2_TRACE_RE = /\[\s+minimal\s+=\s+minimal\s+\]/;
...
-    result.stderr.includes(LAYER2_TRACE_MARKER),
-    `entrypoint ${entrypoint} should reach Layer 2 (expected ${LAYER2_TRACE_MARKER} in trace); stderr tail: ${result.stderr.slice(-400)}`
+    LAYER2_TRACE_RE.test(result.stderr),
+    `entrypoint ${entrypoint} should reach Layer 2 (expected minimal-profile check in trace); stderr tail: ${result.stderr.slice(-400)}`
...
-    !result.stderr.includes(LAYER2_TRACE_MARKER),
-    `entrypoint ${entrypoint} should stop at Layer 1 (Layer 2 marker ${LAYER2_TRACE_MARKER} should NOT appear); stderr tail: ${result.stderr.slice(-400)}`
+    !LAYER2_TRACE_RE.test(result.stderr),
+    `entrypoint ${entrypoint} should stop at Layer 1 (Layer 2 marker should NOT appear); stderr tail: ${result.stderr.slice(-400)}`

Also applies to: 126-127

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/hooks/observe-entrypoint-allowlist.test.js` around lines 103 - 114, The
current brittle LAYER2_TRACE_MARKER string check in assertAllowedReachesLayer2
should be replaced with a regex-based assertion that matches the semantic
"minimal = minimal" comparison across varying xtrace formats; update the code in
assertAllowedReachesLayer2 (and the analogous check at lines ~126-127) to build
a RegExp like /\bminimal\s*=\s*minimal\b/ (allowing optional surrounding
brackets/quotes and whitespace) and assert that result.stderr.match(...) is
truthy so the test is robust across Bash/xtrace variations; keep runObserve
usage and error messages but swap the exact-string include checks for the regex
match.

---

43-47: ⚡ Quick win

Replace direct console.log usage in the edited test file.

Line 43, Line 46-47, Line 131, and Line 148-149 use console.log. Please switch to a test logger/helper (or process.stdout.write) so this follows repository JS logging rules consistently.

As per coding guidelines, "Warn about console.log statements in edited files".

Also applies to: 131-132, 148-149

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/hooks/observe-entrypoint-allowlist.test.js` around lines 43 - 47,
Replace direct console.log calls used in the test's try/catch reporter (the
lines that print `  ✓ ${name}`, `  ✗ ${name}`, and the error message using
`err.message`) with the project's test logger or process.stdout.write; locate
the usages that reference the local variables `name`, `passed`, and `err` and
swap each console.log to the shared test logging helper (or call
process.stdout.write with the same formatted strings) so logging follows
repository JS logging rules across all occurrences in this test.