Skip to content

fix(cli): include comment author in review output - #690

Merged
agavra merged 2 commits into
agavra:mainfrom
MattKotsenas:review-comments-author
Sep 7, 2026
Merged

agavra merged 2 commits into
agavra:mainfrom
MattKotsenas:review-comments-author

Conversation

@MattKotsenas

Copy link
Copy Markdown
Contributor

fix(cli): include comment author in review output

Summary

This PR includes each persisted comment's author in the JSON emitted by
tuicr review add and tuicr review comments. Callers can distinguish comment
authors after reading a session instead of retaining the IDs returned when each
comment was added.

Comments added through the CLI use a nonblank --username or JSON
username/author, then a nonblank configured username, then "user".
Comments written in the TUI use the configured username, or "user" when it
is unset. Agents should pass an explicit username when attribution must
distinguish their comments from the user's.

Open PR #680 currently says review comments reports no author. This PR adds
that missing field, so the statement in #680 will need updating.

@agavra agavra left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MattKotsenas for the contribution! This looks good to me.

@MattKotsenas
MattKotsenas force-pushed the review-comments-author branch from fff2c65 to 7b18c83 Compare September 7, 2026 21:06
@agavra
agavra merged commit f9719c8 into agavra:main Sep 7, 2026
5 checks passed
@MattKotsenas
MattKotsenas deleted the review-comments-author branch September 8, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants