Repository navigation
skill: put the tmux review pane where its caller is - #736
Merged
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #735
tuicr-wrapper.shcalledsplit-window,select-paneanddisplay-messagewithout a target, so tmux used the active pane of the client. When an agent launches a review from a pane the human is not looking at, the review lands in the pane of the human and steals focus.Changes:
$TMUX_PANE(the pane the wrapper runs in) for the split, falling back to the current pane if unset.#{pane_height}instead of#{window_height}.select-paneto the new pane when the caller pane is already active in its window; otherwise leave focus alone and log it.This is the tmux counterpart of #687, which fixed the same behaviour for zellij.
Tested on tmux 3.6a: a split from a background pane opens in the window of that pane and the active window does not change.
🤖 Generated with Claude Code