Repository navigation
Conversation
Upgrade gradle
add common pool strategy
Rework exclude include annotations
Test suite loader fix
* add teamcity client * add fork sorting common module. add basic entities * add fork-sorting-teamcity module. this module incapsulate teamcity client and mapping * add Teamcity based sorting strategy * add dependencies between modules * add chart page * move history manager and testexecution reporter to stat package * return optional from test history manager * fix summary printer injector * cleanup properties * use long timestamp instead of string format * use timestamp instead of string * change format of report * rework loader * rename package * rework teamcity loader * remove test.yaml * temp solution * fix compile time errors * add testMetrics getter * remove dependency to fork-stat-teamcity from fork-runner * move teamcity client to fork-stat-teamcity * add queue provider * use TestCaseEventFactory instead of static factory methods * remove testHistoryManager * remove unused AuthConfig * removed unused function * fix chart * add info about idling * remove logs * fix comments * change tick format * experiment with PriorityBlockingQueue * fix codeformat
cdsap
reviewed
Dec 20, 2017
| api "commons-io:commons-io:2.5" | ||
| api "org.apache.commons:commons-lang3:3.4" | ||
| api "com.github.spullara.mustache.java:compiler:0.8.0" | ||
| api "com.google.code.gson:gson:$GSON_VERSION" |
There was a problem hiding this comment.
why mixing defined versions with hardcoded?
Author
There was a problem hiding this comment.
@cdsap good question, I'll move all dependencies description to dependencies.gradle
| } | ||
|
|
||
| private final List<TestHistory> testHistories = new ArrayList<>(); | ||
| private final Map<String, TestMetric> testMetris = new HashMap<>(); |
| return annotations -> { | ||
| if (Strings.isNullOrEmpty(annotations)) return emptyList(); | ||
| return Arrays.stream(annotations.split(",")) | ||
| .map(c -> "L" + c.replace('.', '/').trim() + ';') |
Author
There was a problem hiding this comment.
L means it can contain references to objects
example: java.lang.String convert to [Ljava.lang.String;
| @@ -0,0 +1,51 @@ | |||
|
|
|||
| @@ -0,0 +1,54 @@ | |||
|
|
|||
| import java.util.Comparator; | ||
|
|
||
| class TestComparator implements Comparator<TestCaseEvent> { | ||
| private static Comparator<TestCaseEvent> getDefaultComparator() { |
There was a problem hiding this comment.
would be nice one comment about this Comparator
| @@ -0,0 +1,19 @@ | |||
| package com.shazam.fork.summary.executiontimeline; | |||
There was a problem hiding this comment.
strange but github is not giving the highlight of java for these classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.