Skip to content

Release 3.0.0-alpha1 - #16

Merged
tagantroy merged 25 commits into
masterfrom
develop
Dec 20, 2017
Merged

tagantroy merged 25 commits into
masterfrom
develop

Conversation

@tagantroy

Copy link
Copy Markdown

No description provided.

Ivan Balaksha and others added 20 commits November 14, 2017 18:06
* add teamcity client

* add fork sorting common module. add basic entities

* add fork-sorting-teamcity module. this module incapsulate teamcity client and mapping

* add Teamcity based sorting strategy

* add dependencies between modules

* add chart page

* move history manager and testexecution reporter to stat package

* return optional from test history manager

* fix summary printer injector

* cleanup properties

* use long timestamp instead of string format

* use timestamp instead of string

* change format of report

* rework loader

* rename package

* rework teamcity loader

* remove test.yaml

* temp solution

* fix compile time errors

* add testMetrics getter

* remove dependency to fork-stat-teamcity from fork-runner

* move teamcity client to fork-stat-teamcity

* add queue provider

* use TestCaseEventFactory instead of static factory methods

* remove testHistoryManager

* remove unused AuthConfig

* removed unused function

* fix chart

* add info about idling

* remove logs

* fix comments

* change tick format

* experiment with PriorityBlockingQueue

* fix codeformat
@tagantroy
tagantroy requested a review from cdsap December 19, 2017 06:53

@cdsap cdsap left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things.
Looks great Ivan!!!

Comment thread fork-common/build.gradle
api "commons-io:commons-io:2.5"
api "org.apache.commons:commons-lang3:3.4"
api "com.github.spullara.mustache.java:compiler:0.8.0"
api "com.google.code.gson:gson:$GSON_VERSION"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why mixing defined versions with hardcoded?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdsap good question, I'll move all dependencies description to dependencies.gradle

}

private final List<TestHistory> testHistories = new ArrayList<>();
private final Map<String, TestMetric> testMetris = new HashMap<>();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testMetrics

return annotations -> {
if (Strings.isNullOrEmpty(annotations)) return emptyList();
return Arrays.stream(annotations.split(","))
.map(c -> "L" + c.replace('.', '/').trim() + ';')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this L?

@tagantroy tagantroy Dec 20, 2017 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L means it can contain references to objects

example: java.lang.String convert to [Ljava.lang.String;

@@ -0,0 +1,51 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty

@@ -0,0 +1,54 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty

import java.util.Comparator;

class TestComparator implements Comparator<TestCaseEvent> {
private static Comparator<TestCaseEvent> getDefaultComparator() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice one comment about this Comparator

@@ -0,0 +1,19 @@
package com.shazam.fork.summary.executiontimeline;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange but github is not giving the highlight of java for these classes

@tagantroy
tagantroy merged commit e3981c4 into master Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants