Skip to content

feat(electrum): read seeds from before 2.0 - #209

Merged
oritwoen merged 1 commit into
mainfrom
feat/electrum-old-seeds
Oct 1, 2026
Merged

oritwoen merged 1 commit into
mainfrom
feat/electrum-old-seeds

Conversation

@aeitwoen

@aeitwoen aeitwoen commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Closes #181

This turns old Electrum seeds from a flat refusal into addresses: keys_electrum_wallet_derive takes them by change and index, master public key included. The test vectors come from Electrum 4.8.1 itself, since these seeds never had a spec outside its code.

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner October 1, 2026 21:10
@aeitwoen aeitwoen self-assigned this Oct 1, 2026
@coldtea-pr-lens

coldtea-pr-lens Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

◈ PR Lens

🟢 +1 new · 🟠 ~7 changed · 🔴 -0 removed · 1 flow · 21 files · commit 8b5cf66


Architecture

Architecture diagram for agntn/keys at 8b5cf66

8 components touched across 7 lanes.

Play the interactive walkthrough


Inside the changed components — 2 views

Component view — Electrum seed engine

Internal components of the Electrum seed engine handling word decoding, seed stretching, and public key derivation.

Architecture view of Component view — Electrum seed engine in agntn/keys

Component view — Tool dispatch & address derivation

Tool schemas, dispatcher validation, and blockchain address derivation for Electrum wallet requests.

Architecture view of Component view — Tool dispatch & address derivation in agntn/keys

Data flow

Data flow diagram for agntn/keys at 8b5cf66

Deriving an old Electrum wallet

Follow each request, response and payload


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • Push a commit and the drawing stays, with a note that it is out of date. Tick Redraw in the note to draw the new head

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://feat-electrum-old-seeds-agntn-keys.oritwoen.workers.dev (commit 8b5cf66)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://089ef38b-agntn-keys.oritwoen.workers.dev 8b5cf66 2026-10-01T21:13:17.978Z Visit the dashboard ↗

@oritwoen
oritwoen merged commit 99b9034 into main Oct 1, 2026
4 checks passed
@oritwoen
oritwoen deleted the feat/electrum-old-seeds branch October 1, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derive old Electrum seeds

2 participants